Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added search request/response processors. #505

Merged
merged 1 commit into from
Aug 14, 2024

Conversation

dblock
Copy link
Member

@dblock dblock commented Aug 13, 2024

Description

Added the simpler search response processors.

Taking over and finishing #440. The split processor doesn't seem to work, opened opensearch-project/OpenSearch#15229.

Issues Resolved

Closes #440.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Contributor

github-actions bot commented Aug 13, 2024

Changes Analysis

Commit SHA: 85ababf
Comparing To SHA: 09824d0

API Changes

Summary

└─┬Components
  ├──[➕] schemas (48828:7)
  ├──[➕] schemas (48861:7)
  ├──[➕] schemas (48777:7)
  ├──[➕] schemas (49087:7)
  ├──[➕] schemas (48987:7)
  ├──[➕] schemas (48751:7)
  ├──[➕] schemas (48907:7)
  ├──[➕] schemas (49107:7)
  ├──[➕] schemas (48916:7)
  ├──[➕] schemas (49070:7)
  ├──[➕] schemas (48929:7)
  └─┬search_pipeline._common:SearchPipelineStructure
    └─┬response_processors
      └─┬Schema
        └──[🔀] $ref (48930:9)❌ 

Document Element Total Changes Breaking Changes
components 12 1
  • BREAKING Changes: 1 out of 12
  • Modifications: 1
  • Additions: 11
  • Breaking Modifications: 1

Report

The full API changes report is available at: https://github.com/opensearch-project/opensearch-api-specification/actions/runs/10375188830/artifacts/1807995138

API Coverage

Before After Δ
Covered (%) 524 (51.32 %) 524 (51.32 %) 0 (0 %)
Uncovered (%) 497 (48.68 %) 497 (48.68 %) 0 (0 %)
Unknown 26 26 0

Copy link
Contributor

Spec Test Coverage Analysis

Total Tested
550 214 (38.91 %)

Signed-off-by: dblock <dblock@amazon.com>
@dblock dblock marked this pull request as ready for review August 13, 2024 18:27
@dblock dblock changed the title Added search response processors. Added search processors. Aug 13, 2024
@dblock dblock changed the title Added search processors. Added search response processors. Aug 13, 2024
@dblock dblock changed the title Added search response processors. Added search request/response processors. Aug 13, 2024
@Xtansia Xtansia merged commit 83eab43 into opensearch-project:main Aug 14, 2024
28 checks passed
@dblock dblock deleted the search-response-processors branch August 14, 2024 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants