Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed content-type for /hot_threads. #543

Merged
merged 1 commit into from
Aug 30, 2024

Conversation

dblock
Copy link
Member

@dblock dblock commented Aug 30, 2024

Description

Fixed content-type for /hot_threads. Added tests.
Moved hotthreads to superseded operations.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: dblock <dblock@amazon.com>
Copy link
Contributor

github-actions bot commented Aug 30, 2024

Changes Analysis

Commit SHA: f3b8bab
Comparing To SHA: b3f9788

API Changes

Summary

└─┬Paths
  ├─┬/_nodes/hotthreads
  │ └─┬GET
  │   ├──[🔀] operationId (13010:20)❌ 
  │   ├─┬Responses
  │   │ └─┬200
  │   │   └──[➕] content (26460:21)
  │   └─┬Extensions
  │     ├──[➖] x-deprecation-message (3302:30)❌ 
  │     └──[➖] x-version-deprecated (3304:29)❌ 
  ├─┬/_cluster/nodes/{node_id}/hot_threads
  │ └─┬GET
  │   └─┬Responses
  │     └─┬200
  │       └──[➕] content (26460:21)
  ├─┬/_cluster/nodes/hot_threads
  │ └─┬GET
  │   └─┬Responses
  │     └─┬200
  │       └──[➕] content (26460:21)
  ├─┬/_cluster/nodes/hotthreads
  │ └─┬GET
  │   ├──[🔀] operationId (12929:20)❌ 
  │   ├─┬Responses
  │   │ └─┬200
  │   │   └──[➕] content (26460:21)
  │   └─┬Extensions
  │     └──[🔀] x-deprecation-message (12933:30)
  ├─┬/_nodes/hot_threads
  │ └─┬GET
  │   └─┬Responses
  │     └─┬200
  │       └──[➕] content (26460:21)
  ├─┬/_nodes/{node_id}/hot_threads
  │ └─┬GET
  │   └─┬Responses
  │     └─┬200
  │       └──[➕] content (26460:21)
  ├─┬/_cluster/nodes/{node_id}/hotthreads
  │ └─┬GET
  │   ├──[🔀] operationId (12956:20)❌ 
  │   ├─┬Responses
  │   │ └─┬200
  │   │   └──[➕] content (26460:21)
  │   └─┬Extensions
  │     └──[🔀] x-deprecation-message (12960:30)
  └─┬/_nodes/{node_id}/hotthreads
    └─┬GET
      ├──[🔀] operationId (12984:20)❌ 
      ├─┬Responses
      │ └─┬200
      │   └──[➕] content (26460:21)
      └─┬Extensions
        ├──[➖] x-deprecation-message (3110:30)❌ 
        └──[➖] x-version-deprecated (3112:29)❌ 

Document Element Total Changes Breaking Changes
paths 18 4
  • BREAKING Changes: 4 out of 18
  • Modifications: 6
  • Removals: 4
  • Additions: 8
  • Breaking Removals: 4
  • Breaking Modifications: 4

Report

The full API changes report is available at: https://github.com/opensearch-project/opensearch-api-specification/actions/runs/10632763599/artifacts/1874573007

API Coverage

Before After Δ
Covered (%) 533 (52.2 %) 533 (52.2 %) 0 (0 %)
Uncovered (%) 488 (47.8 %) 488 (47.8 %) 0 (0 %)
Unknown 26 26 0

Copy link
Contributor

Spec Test Coverage Analysis

Total Tested
559 246 (44.01 %)

Comment on lines +597 to +612
/_cluster/nodes/hotthreads:
superseded_by: /_cluster/nodes/hot_threads
operations:
- GET
/_cluster/nodes/{node_id}/hotthreads:
superseded_by: /_cluster/nodes/{node_id}/hot_threads
operations:
- GET
/_nodes/{node_id}/hotthreads:
superseded_by: /_nodes/{node_id}/hot_threads
operations:
- GET
/_nodes/hotthreads:
superseded_by: /_nodes/hot_threads
operations:
- GET
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Loving seeing a bunch of deletions thanks to this 🥳

@nhtruong nhtruong merged commit a83d5b2 into opensearch-project:main Aug 30, 2024
16 checks passed
@dblock dblock deleted the hot-threads branch August 30, 2024 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants