-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed content-type for /hot_threads. #543
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dblock
requested review from
harshavamsi,
sachetalva,
nhtruong,
Xtansia,
VachaShah,
Tokesh and
aabeshov
as code owners
August 30, 2024 12:33
Signed-off-by: dblock <dblock@amazon.com>
Changes AnalysisCommit SHA: f3b8bab API ChangesSummary
ReportThe full API changes report is available at: https://github.com/opensearch-project/opensearch-api-specification/actions/runs/10632763599/artifacts/1874573007 API Coverage
|
Spec Test Coverage Analysis
|
nhtruong
approved these changes
Aug 30, 2024
Comment on lines
+597
to
+612
/_cluster/nodes/hotthreads: | ||
superseded_by: /_cluster/nodes/hot_threads | ||
operations: | ||
- GET | ||
/_cluster/nodes/{node_id}/hotthreads: | ||
superseded_by: /_cluster/nodes/{node_id}/hot_threads | ||
operations: | ||
- GET | ||
/_nodes/{node_id}/hotthreads: | ||
superseded_by: /_nodes/{node_id}/hot_threads | ||
operations: | ||
- GET | ||
/_nodes/hotthreads: | ||
superseded_by: /_nodes/hot_threads | ||
operations: | ||
- GET |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Loving seeing a bunch of deletions thanks to this 🥳
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed content-type for /hot_threads. Added tests.
Moved
hotthreads
to superseded operations.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.