Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: cluster settings can be flat. #545

Merged
merged 1 commit into from
Aug 30, 2024

Conversation

dblock
Copy link
Member

@dblock dblock commented Aug 30, 2024

Description

Cluster settings don't always return nested objects, they can be flat key/value pairs.

Here's the default output with include_defaults on the test cluster, note processors.

    "logger": {
      "level": "INFO"
    },
    "processors": "10",
    "ingest": {
      "geoip": {
        "cache_size": "1000"
      },

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Contributor

github-actions bot commented Aug 30, 2024

Changes Analysis

Commit SHA: 5a7af53
Comparing To SHA: 3f806a1

API Changes

Summary

└─┬Paths
  └─┬/_cluster/settings
    └─┬GET
      └─┬Responses
        └─┬200
          └─┬application/json
            └─┬Schema
              ├─┬transient
              │ └──[🔀] additionalProperties (25466:39)❌ 
              ├─┬defaults
              │ └──[🔀] additionalProperties (25469:39)❌ 
              └─┬persistent
                └──[🔀] additionalProperties (25463:39)❌ 

Document Element Total Changes Breaking Changes
paths 3 3
  • BREAKING Changes: 3 out of 3
  • Modifications: 3
  • Breaking Modifications: 3

Report

The full API changes report is available at: https://github.com/opensearch-project/opensearch-api-specification/actions/runs/10637361428/artifacts/1875965144

API Coverage

Before After Δ
Covered (%) 533 (52.2 %) 533 (52.2 %) 0 (0 %)
Uncovered (%) 488 (47.8 %) 488 (47.8 %) 0 (0 %)
Unknown 26 26 0

Copy link
Contributor

github-actions bot commented Aug 30, 2024

Spec Test Coverage Analysis

Total Tested
559 249 (44.54 %)

nhtruong
nhtruong previously approved these changes Aug 30, 2024
Signed-off-by: dblock <dblock@amazon.com>
@nhtruong nhtruong merged commit 30f1846 into opensearch-project:main Aug 30, 2024
17 checks passed
@dblock dblock deleted the cluster-settings branch August 30, 2024 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants