-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Truncate errors at 256 characters, fix flaky test. #556
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -152,8 +152,9 @@ export class ConsoleResultLogger implements ResultLogger { | |
} | ||
|
||
#maybe_shorten_error_message(message: string | undefined): string | undefined { | ||
if (message === undefined || message.length <= 128 || this._verbose) return message | ||
const part = message.split(',')[0] | ||
const cut_at = 256 | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Nit: This is better off as a configurable number in the constructor, esp when we refactor the test framework to be a standalone product. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'll leave it as is for now, but we can expose it as an option when someone actually wants to change this value programmatically. |
||
if (message === undefined || message.length <= cut_at || this._verbose) return message | ||
const part = message.substring(0, cut_at) | ||
return part + (part !== message ? ', ...' : '') | ||
} | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shard may be still relocating, retry.