Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split Percentage into PercentageNumber, PercentageString #573

Merged
merged 1 commit into from
Sep 13, 2024

Conversation

Jakob3xD
Copy link
Contributor

Description

  • Split Percentage into PercentageNumber, PercentageString
  • Add missing fields
  • Use reference instead of type for percentage fields

Issues Resolved

Related to #423

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Jakob Hahn <jakob.hahn@hetzner.com>
Copy link
Contributor

Changes Analysis

Commit SHA: cd7ef30
Comparing To SHA: 97cfa9b

API Changes

Summary

└─┬Components
  ├──[➖] schemas (29541:7)❌ 
  ├──[➕] schemas (29541:7)
  ├──[➕] schemas (29543:7)
  ├─┬nodes._common:ShardResourceUsageStatsDetail
  │ ├─┬cpu_utilization_percent
  │ │ └──[🔀] $ref (29543:13)❌ 
  │ └─┬memory_utilization_percent
  │   └──[🔀] $ref (29543:13)❌ 
  ├─┬cat.allocation:AllocationRecord
  │ └─┬disk.percent
  │   └─┬ONEOF
  │     └──[🔀] $ref (29543:13)❌ 
  ├─┬nodes._common:ExtendedMemoryStats
  │ └─┬ALLOF
  │   ├─┬used_percent
  │   │ └──[🔀] $ref (29541:13)❌ 
  │   └─┬free_percent
  │     └──[🔀] $ref (29541:13)❌ 
  ├─┬indices.recovery:RecoveryFiles
  │ └─┬percent
  │   └──[🔀] $ref (29543:13)❌ 
  ├─┬nodes._common:Processor
  │ └──[➕] properties (49477:9)
  ├─┬nodes._common:ShardResourceUsageStatsIoUsageStats
  │ └─┬max_io_utilization_percent
  │   └──[🔀] $ref (29543:13)❌ 
  ├─┬indices.recovery:TranslogStatus
  │ └─┬percent
  │   └──[🔀] $ref (29543:13)❌ 
  ├─┬cat.nodes:NodesRecord
  │ ├─┬ram.percent
  │ │ └──[🔀] $ref (29543:13)❌ 
  │ ├─┬disk.used_percent
  │ │ └──[🔀] $ref (29543:13)❌ 
  │ ├─┬file_desc.percent
  │ │ └──[🔀] $ref (29543:13)❌ 
  │ └─┬heap.percent
  │   └──[🔀] $ref (29543:13)❌ 
  ├─┬cat.recovery:RecoveryRecord
  │ ├─┬files_percent
  │ │ └──[🔀] $ref (29543:13)❌ 
  │ ├─┬translog_ops_percent
  │ │ └──[🔀] $ref (29543:13)❌ 
  │ └─┬bytes_percent
  │   └──[🔀] $ref (29543:13)❌ 
  ├─┬cat.health:HealthRecord
  │ └─┬active_shards_percent
  │   └──[🔀] $ref (29543:13)❌ 
  ├─┬cluster.health:HealthResponseBody
  │ ├──[➕] properties (43904:9)
  │ └─┬active_shards_percent_as_number
  │   └──[🔀] $ref (29541:13)❌ 
  ├─┬cat._common:CatSegmentReplicationRecord
  │ ├─┬bytes_percent
  │ │ └──[🔀] $ref (29543:13)❌ 
  │ └─┬files_percent
  │   └──[🔀] $ref (29543:13)❌ 
  ├─┬indices.recovery:RecoveryBytes
  │ └─┬percent
  │   └──[🔀] $ref (29543:13)❌ 
  ├─┬nodes._common:JvmMemoryStats
  │ └─┬heap_used_percent
  │   └──[🔀] $ref (29541:13)❌ 
  ├─┬cluster.stats:ClusterProcessCpu
  │ └─┬percent
  │   └──[🔀] $ref (29541:13)❌ 
  └─┬cluster.stats:OperatingSystemMemoryInfo
    ├─┬free_percent
    │ └──[🔀] $ref (29541:13)❌ 
    └─┬used_percent
      └──[🔀] $ref (29541:13)❌ 

Document Element Total Changes Breaking Changes
components 29 27
  • BREAKING Changes: 27 out of 29
  • Modifications: 24
  • Removals: 1
  • Additions: 4
  • Breaking Removals: 1
  • Breaking Modifications: 24

Report

The full API changes report is available at: https://github.com/opensearch-project/opensearch-api-specification/actions/runs/10846401870/artifacts/1929250196

API Coverage

Before After Δ
Covered (%) 545 (53.38 %) 545 (53.38 %) 0 (0 %)
Uncovered (%) 476 (46.62 %) 476 (46.62 %) 0 (0 %)
Unknown 26 26 0

Copy link
Contributor

Spec Test Coverage Analysis

Total Tested
571 282 (49.39 %)

@dblock dblock merged commit 584d525 into opensearch-project:main Sep 13, 2024
25 checks passed
@Jakob3xD Jakob3xD deleted the jh-percentage branch September 13, 2024 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants