Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove extra free-format object in create/index/delete operation from… #582

Conversation

amberzsy
Copy link
Contributor

@amberzsy amberzsy commented Sep 16, 2024

… bulk api

Description

remove extra free-format object in create/index/delete operation in bulk

Issues Resolved

Closes #581

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

… bulk api

Signed-off-by: amberzsy <xxamber998@gmail.com>
Signed-off-by: amberzsy <xxamber998@gmail.com>
@dblock
Copy link
Member

dblock commented Sep 16, 2024

Thanks @amberzsy. I appreciate you opening the issues first for these and other bugs, too, but if you want to save yourself some time, feel free to just open the PR with the description of what you're fixing if it's easier!

Also if you say "Closes XYZ" in the PR description it will auto-close the issue when the PR is merged.

@dblock dblock merged commit f167e0d into opensearch-project:main Sep 16, 2024
18 checks passed
Copy link
Contributor

Changes Analysis

Commit SHA: 3bf9a47
Comparing To SHA: c2c666f

API Changes

Summary

└─┬Components
  ├─┬_core.bulk:DeleteOperation
  │ └──[🔀] $ref (39793:13)❌ 
  ├─┬_core.bulk:CreateOperation
  │ └──[🔀] $ref (39791:13)❌ 
  └─┬_core.bulk:IndexOperation
    └──[🔀] $ref (39795:13)❌ 

Document Element Total Changes Breaking Changes
components 3 3
  • BREAKING Changes: 3 out of 3
  • Modifications: 3
  • Breaking Modifications: 3

Report

The full API changes report is available at: https://github.com/opensearch-project/opensearch-api-specification/actions/runs/10876980712/artifacts/1935979850

API Coverage

Before After Δ
Covered (%) 560 (54.85 %) 560 (54.85 %) 0 (0 %)
Uncovered (%) 461 (45.15 %) 461 (45.15 %) 0 (0 %)
Unknown 25 25 0

Copy link
Contributor

Spec Test Coverage Analysis

Total Tested
585 290 (49.57 %)

dblock pushed a commit to dblock/opensearch-api-specification that referenced this pull request Sep 23, 2024
opensearch-project#582)

* remove extra free-format object in create/index/delete operation from bulk api

Signed-off-by: amberzsy <xxamber998@gmail.com>

* add CHANGELOG

Signed-off-by: amberzsy <xxamber998@gmail.com>

---------

Signed-off-by: amberzsy <xxamber998@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] extra free-format type:object in index/create/delete operation
2 participants