-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update API specifications for k-NN 2.17 changes #588
Conversation
Signed-off-by: Ryan Bogan <rbogan@amazon.com>
Signed-off-by: Ryan Bogan <rbogan@amazon.com>
Changes AnalysisCommit SHA: 6f8c43d API ChangesSummary
ReportThe full API changes report is available at: https://github.com/opensearch-project/opensearch-api-specification/actions/runs/11020408398/artifacts/1973422498 API Coverage
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good.
- Adopt the movies/books theme in the examples since we plan to use those in the documentation.
- Add 2.17 to CI/CD, iterate to green (
npm run lint--fix
, etc.).
…og message Signed-off-by: Ryan Bogan <rbogan@amazon.com>
Signed-off-by: Ryan Bogan <rbogan@amazon.com>
@dblock Do I need to change the sha ref in the workflow file to get 3.0 to pass? |
Yes, because that's If you have a moment, since you are updating 3.0, also check whether the build you're picking fixes
|
Sure, I'll take a look |
method_parameters: | ||
type: object | ||
x-version-added: '2.16' | ||
additionalProperties: | ||
type: number | ||
rescore: | ||
type: object | ||
x-version-added: '2.17' | ||
additionalProperties: | ||
type: number |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if I understand this correctly, the additionalProperties are more of a map whose values will always be of type number? correct?
if the above understanding is correct, then my worry is going forward we can add more parameters and those parameters might not be of number type. Can use some type like object or anything that can allow us to specify number, strings as additional parameter values in future.
@dblock thoughts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we add them in the future, we can update this with:
anyOf:
type:
number
string
etc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@navneet1v you're correct, and @ryanbogan is also correct, if the schema today is a number, leave it as such, and tomorrow it can be extended when it can actually be something else.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure make sense. In case we update in future, I am hoping the changes are BWC. can you please confirm that.
@dblock
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes.
Signed-off-by: Ryan Bogan <rbogan@amazon.com>
Looks like the asynchronous search tests are still failing on 3.0, will add the version checks again |
Signed-off-by: Ryan Bogan <rbogan@amazon.com>
Signed-off-by: Ryan Bogan <rbogan@amazon.com>
Spec Test Coverage Analysis
|
Description
This PR updates the API specifications to be consistent with changes released for k-NN in OpenSearch 2.17.
These changes include adding rescore and oversampling factor to a k-NN query, and adding mode and compression options during index creation and training models.
Issues Resolved
#583
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.