Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unsupported runtime fields types #634

Merged

Conversation

Xtansia
Copy link
Collaborator

@Xtansia Xtansia commented Oct 22, 2024

Description

Remove unsupported runtime fields types

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Thomas Farr <tsfarr@amazon.com>
Signed-off-by: Thomas Farr <tsfarr@amazon.com>
Copy link
Contributor

github-actions bot commented Oct 22, 2024

Changes Analysis

Commit SHA: b93336e
Comparing To SHA: 56081a4

API Changes

Summary

├─┬Paths
│ ├─┬/_search
│ │ ├─┬GET
│ │ │ └─┬Requestbody
│ │ │   └─┬application/json
│ │ │     └─┬Schema
│ │ │       └──[➖] properties (26400:15)❌ 
│ │ └─┬POST
│ │   └─┬Requestbody
│ │     └─┬application/json
│ │       └─┬Schema
│ │         └──[➖] properties (26400:15)❌ 
│ ├─┬/_field_caps
│ │ ├─┬GET
│ │ │ └─┬Requestbody
│ │ │   └─┬application/json
│ │ │     └─┬Schema
│ │ │       └──[➖] properties (25425:15)❌ 
│ │ └─┬POST
│ │   └─┬Requestbody
│ │     └─┬application/json
│ │       └─┬Schema
│ │         └──[➖] properties (25425:15)❌ 
│ ├─┬/{index}/_search
│ │ ├─┬GET
│ │ │ └─┬Requestbody
│ │ │   └─┬application/json
│ │ │     └─┬Schema
│ │ │       └──[➖] properties (26400:15)❌ 
│ │ └─┬POST
│ │   └─┬Requestbody
│ │     └─┬application/json
│ │       └─┬Schema
│ │         └──[➖] properties (26400:15)❌ 
│ ├─┬/{index}/_mapping
│ │ ├─┬PUT
│ │ │ └─┬Requestbody
│ │ │   └─┬application/json
│ │ │     └─┬Schema
│ │ │       └──[➖] properties (25655:15)❌ 
│ │ └─┬POST
│ │   └─┬Requestbody
│ │     └─┬application/json
│ │       └─┬Schema
│ │         └──[➖] properties (25655:15)❌ 
│ └─┬/{index}/_field_caps
│   ├─┬GET
│   │ └─┬Requestbody
│   │   └─┬application/json
│   │     └─┬Schema
│   │       └──[➖] properties (25425:15)❌ 
│   └─┬POST
│     └─┬Requestbody
│       └─┬application/json
│         └─┬Schema
│           └──[➖] properties (25425:15)❌ 
└─┬Components
  ├──[➖] schemas (38596:7)❌ 
  ├──[➖] schemas (46727:7)❌ 
  ├──[➖] schemas (38573:7)❌ 
  ├──[➖] schemas (38609:7)❌ 
  ├──[➖] schemas (38605:7)❌ 
  ├─┬_core.reindex:Source
  │ └──[➖] properties (41992:9)❌ 
  ├─┬_common.mapping:TypeMapping
  │ └──[➖] properties (38863:9)❌ 
  ├─┬cluster.stats:FieldTypesMappings
  │ └──[➖] properties (46596:9)❌ 
  ├─┬_core.msearch:MultisearchBody
  │ └──[➖] properties (41551:9)❌ 
  └─┬asynchronous_search._common:Search
    └──[➖] properties (43264:9)❌ 

Document Element Total Changes Breaking Changes
components 10 10
paths 10 10
  • BREAKING Changes: 20 out of 20
  • Removals: 20
  • Breaking Removals: 20

Report

The full API changes report is available at: https://github.com/opensearch-project/opensearch-api-specification/actions/runs/11453155476/artifacts/2085953615

API Coverage

Before After Δ
Covered (%) 588 (57.59 %) 588 (57.59 %) 0 (0 %)
Uncovered (%) 433 (42.41 %) 433 (42.41 %) 0 (0 %)
Unknown 29 29 0

Copy link
Contributor

Spec Test Coverage Analysis

Total Tested
504 317 (62.9 %)

@dblock
Copy link
Member

dblock commented Oct 22, 2024

Thanks, for the equivalent of this functionality see opensearch-project/OpenSearch#1133.

@dblock dblock merged commit 352e620 into opensearch-project:main Oct 22, 2024
19 checks passed
@Xtansia Xtansia deleted the remove/unsupported-runtime-fields-types branch October 22, 2024 20:28
@Xtansia
Copy link
Collaborator Author

Xtansia commented Oct 22, 2024

Created #636 to track it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants