-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add adjust_pure_negative for bool queries #641
Add adjust_pure_negative for bool queries #641
Conversation
Signed-off-by: Chenyang Ji <cyji@amazon.com>
Changes AnalysisCommit SHA: cefc17c API ChangesSummary
ReportThe full API changes report is available at: https://github.com/opensearch-project/opensearch-api-specification/actions/runs/11506459283/artifacts/2100973119 API Coverage
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Chatted with @ansjcy, this is likely not the right fix.
The query container should document all the fields, this is not user-defined data.
@dblock just updated the PR based on our discussion. Let me know if this looks good to you! Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, we just need CI to pass.
Spec Test Coverage Analysis
|
Signed-off-by: Chenyang Ji <cyji@amazon.com>
f34d32d
to
cefc17c
Compare
Description
The Query Insights API spec depends on the core specifications for the source fields in queries. The issues reported in #638 stem from unexpected fields not defined in the QueryContainer spec. This PR fixes the bug by adding the
adjust_pure_negative
field in bool queries spec.Issues Resolved
Fixes #638
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.