Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add adjust_pure_negative for bool queries #641

Merged
merged 2 commits into from
Oct 24, 2024

Conversation

ansjcy
Copy link
Member

@ansjcy ansjcy commented Oct 24, 2024

Description

The Query Insights API spec depends on the core specifications for the source fields in queries. The issues reported in #638 stem from unexpected fields not defined in the QueryContainer spec. This PR fixes the bug by adding the adjust_pure_negative field in bool queries spec.

Issues Resolved

Fixes #638

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Chenyang Ji <cyji@amazon.com>
Copy link
Contributor

github-actions bot commented Oct 24, 2024

Changes Analysis

Commit SHA: cefc17c
Comparing To SHA: abc7163

API Changes

Summary

└─┬Components
  └─┬_common.query_dsl:BoolQuery
    ├─┬ALLOF
    │ └──[🔀] $ref (40122:13)❌ 
    └─┬ALLOF
      └──[🔀] $ref (38924:11)❌ 

Document Element Total Changes Breaking Changes
components 2 4
  • BREAKING Changes: 4 out of 2
  • Modifications: 2
  • Breaking Modifications: 2

Report

The full API changes report is available at: https://github.com/opensearch-project/opensearch-api-specification/actions/runs/11506459283/artifacts/2100973119

API Coverage

Before After Δ
Covered (%) 588 (57.59 %) 588 (57.59 %) 0 (0 %)
Uncovered (%) 433 (42.41 %) 433 (42.41 %) 0 (0 %)
Unknown 30 30 0

@ansjcy ansjcy changed the title allow additional properties for source field Generalizes the query field in Query Insights spec Oct 24, 2024
Copy link
Member

@dblock dblock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Chatted with @ansjcy, this is likely not the right fix.

The query container should document all the fields, this is not user-defined data.

@ansjcy ansjcy changed the title Generalizes the query field in Query Insights spec Add adjust_pure_negative for bool queries Oct 24, 2024
@ansjcy
Copy link
Member Author

ansjcy commented Oct 24, 2024

@dblock just updated the PR based on our discussion. Let me know if this looks good to you! Thanks.

Copy link
Member

@dblock dblock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, we just need CI to pass.

CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Contributor

Spec Test Coverage Analysis

Total Tested
505 317 (62.77 %)

Signed-off-by: Chenyang Ji <cyji@amazon.com>
@ansjcy ansjcy force-pushed the fix-query-insights-spec-tests branch from f34d32d to cefc17c Compare October 24, 2024 19:52
@dblock dblock merged commit 54f0af9 into opensearch-project:main Oct 24, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-changelog No need to update CHANGELOG.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Query insights tests fail on first pass
2 participants