Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documented docker container testing. #642

Merged
merged 1 commit into from
Oct 24, 2024

Conversation

dblock
Copy link
Member

@dblock dblock commented Oct 24, 2024

Description

Added a testing guide for CI, related to opensearch-project/opensearch-build#5130.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: dblock <dblock@amazon.com>
Copy link
Contributor

Changes Analysis

Commit SHA: f005be1
Comparing To SHA: abc7163

API Changes

Summary

NO CHANGES

Report

The full API changes report is available at: https://github.com/opensearch-project/opensearch-api-specification/actions/runs/11505619148/artifacts/2100711636

API Coverage

Before After Δ
Covered (%) 588 (57.59 %) 588 (57.59 %) 0 (0 %)
Uncovered (%) 433 (42.41 %) 433 (42.41 %) 0 (0 %)
Unknown 30 30 0

Use the following command to retrieve the manifest of a given build to make it easier to identify a SHA that includes all the plugins.

```bash
$ docker run -it --entrypoint bash opensearchstaging/opensearch:2.18.0@sha256:4445e195c53992038891519dc3be0d273cdaad1b047943d68921168ed243e7e9 -c "cat /usr/share/opensearch/manifest.yml"
Copy link
Member

@peterzhuamazon peterzhuamazon Oct 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonder if we should lock the sha here, opensearch:2.18.0 should be enough to retrieve from 2.18.0.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2.18 has not shipped, therefore this becomes a moving target and we have to lock at a given SHA. Releases hopefully have everything, but here the whole point is to show how to retrieve the manifest from a given build.

@nhtruong nhtruong merged commit 7bf34a4 into opensearch-project:main Oct 24, 2024
5 of 13 checks passed
@dblock dblock deleted the add-testing-guide branch October 24, 2024 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-changelog No need to update CHANGELOG.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants