Build OpenAPI spec on PR and correct path #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Thomas Farr <tsfarr@amazon.com>
Xtansia
requested review from
abhivka7,
dblock,
harshavamsi,
pgtgrly,
sachetalva,
nhtruong and
VachaShah
as code owners
VachaShah
reviewed
Apr 11, 2023
| uses: actions/upload-artifact@v3 | ||
| with: | ||
| name: opensearch-openapi | ||
| path: ./OpenSearch.openapi.json |
There was a problem hiding this comment.
Is this uploading artifact step so that it can be used in other workflows? Or some other purpose?
There was a problem hiding this comment.
Purely just for ease of pulling the built spec from PRs and such, not necessary though. Can remove it if preferred
There was a problem hiding this comment.
Makes sense. We can certainly keep it.
VachaShah
approved these changes
Apr 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Build the OpenAPI spec on PR to validate the Smithy model, not only main builds.
Also correct the path to the built spec that changed due to #73
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.