Fix IT bug #350
Merged
Fix IT bug #350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Finn Roblin <finnrobl@amazon.com>
finnroblin
requested review from
IanHoang,
gkamat,
beaioun,
cgchinmay,
rishabh6788 and
VijayanB
as code owners
Closed
IanHoang
approved these changes
Jul 19, 2024
IanHoang
added
backport 2
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jul 19, 2024
Signed-off-by: Finn Roblin <finnrobl@amazon.com> (cherry picked from commit b7ff271) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Merged
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jul 19, 2024
Signed-off-by: Finn Roblin <finnrobl@amazon.com> (cherry picked from commit b7ff271) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Merged
IanHoang
pushed a commit
that referenced
this pull request
Jul 19, 2024
IanHoang
pushed a commit
that referenced
this pull request
Jul 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds default values to vector search workload.json and procedures to fix failing "list workloads" integration test (#348).
Dimension defaults to -1 to pass validation for
list workloadscommand and to indicate thattarget_index_dimensionis a required parameter in thetrain-testprocedure.Tested manually and the previously failing integration tests on my fork pass. A
http_logsexecute-test command fails, but I think is unrelated as I didn't make changes to that code path as part of this or the earlier PR.Issues Resolved
Closes #348
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.