-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rename params with default operation names in http-logs #499
Conversation
Signed-off-by: Michael Oviedo <mikeovi@amazon.com>
f9feedf
to
eff4d50
Compare
Signed-off-by: Michael Oviedo <mikeovi@amazon.com> (cherry picked from commit 2e8adf8) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-1 1
# Navigate to the new working tree
pushd ../.worktrees/backport-1
# Create a new branch
git switch --create backport/backport-499-to-1
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 2e8adf8ed75a239e0bd45a87e46d5003acdb7c27
# Push it to GitHub
git push --set-upstream origin backport/backport-499-to-1
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-1 Then, create a pull request where the |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-3 3
# Navigate to the new working tree
pushd ../.worktrees/backport-3
# Create a new branch
git switch --create backport/backport-499-to-3
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 2e8adf8ed75a239e0bd45a87e46d5003acdb7c27
# Push it to GitHub
git push --set-upstream origin backport/backport-499-to-3
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-3 Then, create a pull request where the |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-7 7
# Navigate to the new working tree
pushd ../.worktrees/backport-7
# Create a new branch
git switch --create backport/backport-499-to-7
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 2e8adf8ed75a239e0bd45a87e46d5003acdb7c27
# Push it to GitHub
git push --set-upstream origin backport/backport-499-to-7
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-7 Then, create a pull request where the |
(cherry picked from commit 2e8adf8) Signed-off-by: Michael Oviedo <mikeovi@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Signed-off-by: Michael Oviedo <mikeovi@amazon.com>
Description
There were several tasks in the http-logs workload with 'default' operation values. The new configurable parameters are typically prefixed with the operation value, but these operations in http-logs were renamed to use the 'name' values instead, so there are not several operations with shared parameter names.
Backport to Branches:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.