Fix geonames caused by jinja2 templating #509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ian Hoang <ianhoang16@gmail.com>
IanHoang
requested review from
gkamat,
beaioun,
cgchinmay,
rishabh6788,
VijayanB and
OVI3D0
as code owners
IanHoang
added
backport 2
OVI3D0
approved these changes
Nov 15, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Nov 15, 2024
Signed-off-by: Ian Hoang <ianhoang16@gmail.com> (cherry picked from commit 5de2e2f) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Nov 15, 2024
Signed-off-by: Ian Hoang <ianhoang16@gmail.com> (cherry picked from commit 5de2e2f) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Nov 15, 2024
Signed-off-by: Ian Hoang <ianhoang16@gmail.com> (cherry picked from commit 5de2e2f) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
IanHoang
pushed a commit
that referenced
this pull request
Nov 15, 2024
(cherry picked from commit 5de2e2f) Signed-off-by: Ian Hoang <ianhoang16@gmail.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
IanHoang
pushed a commit
that referenced
this pull request
Nov 15, 2024
(cherry picked from commit 5de2e2f) Signed-off-by: Ian Hoang <ianhoang16@gmail.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
IanHoang
pushed a commit
that referenced
this pull request
Nov 15, 2024
(cherry picked from commit 5de2e2f) Signed-off-by: Ian Hoang <ianhoang16@gmail.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
joshpalis
pushed a commit
to joshpalis/opensearch-benchmark-workloads
that referenced
this pull request
Dec 18, 2024
Signed-off-by: Ian Hoang <ianhoang16@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Integ tests failing due to missing jinja2 template format. Was lacking default values for one of the test procedures in Geonames.
Backport to Branches:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.