Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parameterize index.translog.durability in big5 #524

Closed
wants to merge 1 commit into from

Conversation

OVI3D0
Copy link
Member

@OVI3D0 OVI3D0 commented Dec 11, 2024

Description

Parameterizes index.translog.durability in the big5 workload. Default is still async as the workload is intended to evaluate performance, and is not in itself a production use-case. The user can override this by passing in --workload-params=index_translog_durability:"request" for example.

Issues Resolved

#515

Testing

  • New functionality includes testing

Tested by running big5 with/without new parameter

Backport to Branches:

  • 6
  • 7
  • 1
  • 2
  • 3

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Collaborator

@gkamat gkamat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the parameter to the README file as well, with a very brief explanation of what the parameter is about ("request" flushes the transaction log after every operation to avoid data loss, while "async" batches up the changes for efficiency). Thanks.

@OVI3D0 OVI3D0 requested a review from gkamat December 12, 2024 17:47
Signed-off-by: Michael Oviedo <mikeovi@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants