Change bulk operation for metrics and index templates to support Open… #186
Conversation
…Search 2.0 as a data store Signed-off-by: travisbenedict <travisrb10@gmail.com>
|
This change was discussed a bit in #108. By merging this PR we are dropping support for metrics stores <ES7. This seems fine to me but there are sure to be other cases of ES/OS conflict in the future. It would be good to align on a decision about how to handle any and all of these conflicts going forwards. |
Signed-off-by: travisbenedict <travisrb10@gmail.com>
I completely agree with you. A version support policy is something I'm planning to publish soon. In this particular case I would argue that we implicitly dropped support for Elasticsearch as a data store back in #74 prior to the alpha release |
| if self._cluster_version[0] > 6: | ||
| self.guarded(opensearchpy.helpers.bulk, self._client, items, index=index, chunk_size=5000) | ||
| else: | ||
| self.guarded(opensearchpy.helpers.bulk, self._client, items, index=index, doc_type=doc_type, chunk_size=5000) |
There was a problem hiding this comment.
Can you add some context on why removing metric store support for ES < 6 is needed here?
There was a problem hiding this comment.
Removing support for ES 6 and below is not explicitly needed but would require an additional maintenance burden for us. ES 7 deprecated certain parameters related to put template operations (more info here). If we want to continue supporting ES 6 as a data store we would need to create duplicates of the index templates and add some additional branching logic.
…Search 2.0 as a data store
Signed-off-by: travisbenedict travisrb10@gmail.com
Description
Add support for OpenSearch 2.0 as a metrics data store by updating the MDS index templates, removing the
doc_typeargument from bulk requests and removinginclude_type_namefrom put template requests.Issues Resolved
Closes #150
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.