bring osd 2.0.0 back to ci-runner-centos7-opensearch-dashboards-build… #1720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… due to node version Signed-off-by: Tianle Huang <tianleh@amazon.com>
Codecov Report
@@ Coverage Diff @@
## main #1720 +/- ##
=========================================
Coverage 94.78% 94.78%
Complexity 17 17
=========================================
Files 169 169
Lines 3525 3525
Branches 26 26
=========================================
Hits 3341 3341
Misses 181 181
Partials 3 3 Continue to review full report at Codecov.
|
gaiksaya
approved these changes
Mar 8, 2022
|
@kavilla You okay with this change? I'll merge it then |
kavilla
approved these changes
Mar 8, 2022
There was a problem hiding this comment.
Yeah looks good to me thanks. I referenced the issue here: #1694, I believe we can take args as well and as long as we have NVM installed when can have the image use the correct Node version instead of relying on different CI images to have specific version only installed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… due to node version
Signed-off-by: Tianle Huang tianleh@amazon.com
Description
Follow up on @kavilla 's comment #1715 (comment)
The V1 image has node 10.24.1
The osd image has node 14.18.2 This is needed by OSD 2.0 to run
Issues Resolved
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.