Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove AD&ml-commons; Add qualifier support for opensearch plugins default build.sh #1838

Merged
merged 2 commits into from
Mar 29, 2022

Conversation

ylwu-amzn
Copy link
Contributor

@ylwu-amzn ylwu-amzn commented Mar 28, 2022

Signed-off-by: Yaliang Wu ylwu@amazon.com

Description

Remove AD&ml-commons; Add qualifier support for opensearch plugins default build.sh
SQL plugin depends on ml-commons, we'd better ml-commons earlier.

Issues

Part of #1632

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@ylwu-amzn ylwu-amzn requested a review from a team as a code owner March 28, 2022 20:36
@codecov-commenter
Copy link

codecov-commenter commented Mar 28, 2022

Codecov Report

Merging #1838 (4876bd2) into main (aa26e2d) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main    #1838   +/-   ##
=========================================
  Coverage     94.53%   94.53%           
  Complexity       19       19           
=========================================
  Files           176      176           
  Lines          3622     3622           
  Branches         27       27           
=========================================
  Hits           3424     3424           
  Misses          194      194           
  Partials          4        4           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa26e2d...4876bd2. Read the comment docs.

@peterzhuamazon peterzhuamazon changed the title move ml-commons after job-scheduler Add qualifier support for opensearch plugins default build.sh & move ml-commons after job-scheduler Mar 28, 2022
…lt build.sh

Signed-off-by: Yaliang Wu <ylwu@amazon.com>
@ylwu-amzn ylwu-amzn changed the title Add qualifier support for opensearch plugins default build.sh & move ml-commons after job-scheduler Remove ml-commons; Add qualifier support for opensearch plugins default build.sh Mar 28, 2022
Signed-off-by: Yaliang Wu <ylwu@amazon.com>
@ylwu-amzn ylwu-amzn changed the title Remove ml-commons; Add qualifier support for opensearch plugins default build.sh Remove AD&ml-commons; Add qualifier support for opensearch plugins default build.sh Mar 29, 2022
@peterzhuamazon
Copy link
Member

Since #1839 we cannot run 2.0.0 ci, but 1.1.0 pass locally so merge this PR.

@peterzhuamazon peterzhuamazon merged commit c6110c3 into opensearch-project:main Mar 29, 2022
@gaiksaya
Copy link
Member

I think we should not merge any 2.0.0 changes before fixing the ci. We might introduce bugs unknowingly.
WDYT @dblock @bbarani ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants