Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve test topology check if there is no integ-test #2843

Conversation

peterzhuamazon
Copy link
Member

Signed-off-by: Peter Zhu zhujiaxi@amazon.com

Description

Resolve test topology check if there is no integ-test

Issues Resolved

#2649

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
@peterzhuamazon peterzhuamazon added the bug Something isn't working label Nov 2, 2022
@peterzhuamazon peterzhuamazon self-assigned this Nov 2, 2022
@peterzhuamazon peterzhuamazon requested a review from a team as a code owner November 2, 2022 23:01
@peterzhuamazon peterzhuamazon mentioned this pull request Nov 2, 2022
52 tasks
@codecov-commenter
Copy link

codecov-commenter commented Nov 2, 2022

Codecov Report

Merging #2843 (d37b7a8) into main (6500b40) will decrease coverage by 0.15%.
The diff coverage is 79.13%.

@@            Coverage Diff             @@
##             main    #2843      +/-   ##
==========================================
- Coverage   93.82%   93.66%   -0.16%     
==========================================
  Files         157      158       +1     
  Lines        4242     4373     +131     
==========================================
+ Hits         3980     4096     +116     
- Misses        262      277      +15     
Impacted Files Coverage Δ
src/test_workflow/test_cluster.py 85.33% <40.00%> (-3.24%) ⬇️
src/test_workflow/integ_test/integ_test_suite.py 85.71% <55.55%> (-8.41%) ⬇️
src/manifests/test_manifest.py 85.71% <61.11%> (-11.66%) ⬇️
src/test_workflow/integ_test/topology.py 87.50% <87.50%> (ø)
...workflow/integ_test/integ_test_suite_opensearch.py 92.00% <100.00%> (+0.33%) ⬆️
src/test_workflow/integ_test/local_test_cluster.py 100.00% <100.00%> (ø)
src/test_workflow/integ_test/service_opensearch.py 100.00% <100.00%> (ø)
src/system/os.py 100.00% <0.00%> (+6.25%) ⬆️
src/system/temporary_directory.py 93.33% <0.00%> (+28.88%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@peterzhuamazon peterzhuamazon merged commit ddeb275 into opensearch-project:main Nov 2, 2022
@peterzhuamazon peterzhuamazon deleted the opensearch-test-topology-check-fix-no-integtest branch November 2, 2022 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants