Resolve Window IntegTest copy and startup issues #2892
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Your Name <you@example.com>
52 tasks
prudhvigodithi
approved these changes
Nov 14, 2022
added 2 commits
November 15, 2022 01:13
Signed-off-by: Your Name <you@example.com>
Signed-off-by: Your Name <you@example.com>
Codecov Report
@@ Coverage Diff @@
## main #2892 +/- ##
==========================================
- Coverage 93.72% 93.72% -0.01%
==========================================
Files 158 158
Lines 4401 4414 +13
==========================================
+ Hits 4125 4137 +12
- Misses 276 277 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
rishabh6788
approved these changes
Nov 15, 2022
dblock
reviewed
Nov 15, 2022
| urllib.request.urlretrieve(source, dest) | ||
| # Required to make sure validators.url is checking an actual url with '/' | ||
| # else '\\' will fail the check even if it is a valid url format | ||
| # Ex: https://ci.opensearch.org/ci/dbc/distribution-build-opensearch/2.4.0/6452/windows/x64/zip\builds\opensearch\maven\org\opensearch\client\client-benchmarks\maven-metadata.xml |
There was a problem hiding this comment.
Where does the URL such as https://ci.opensearch.org/ci/dbc/distribution-build-opensearch/2.4.0/6452/windows/x64/zip\builds\opensearch\maven\org\opensearch\client\client-benchmarks\maven-metadata.xml come from? That's an invalid URL that we probably generate from a Windows path somewhere. Let's fix that source rather than hack it here?
dblock
reviewed
Nov 15, 2022
| "opensearch": "./opensearch-windows-install.bat", | ||
| "opensearch-dashboards": "./opensearch-dashboards.bat", | ||
| "opensearch": ".\\opensearch-windows-install.bat", | ||
| "opensearch-dashboards": ".\\opensearch-dashboards.bat", |
There was a problem hiding this comment.
Nit: just realized that DistributionZip is really a DistributionWindowsZip and DistributionTar is really DistributionLinuxTar. Consider renaming.
1 task
mnin
added a commit
to graylog-labs/opensearch-build
that referenced
this pull request
Nov 16, 2022
# By Peter Zhu (8) and others # Via GitHub * upstream/main: (24 commits) Updated manifests. (opensearch-project#2894) Update ref for 2.4.0 with tags (opensearch-project#2906) Fix status syntax for gradle check (opensearch-project#2907) Add the consolidated release notes for 2.4.0 release (opensearch-project#2887) Revert set output command (opensearch-project#2903) Fix status code for gradle check with retry (opensearch-project#2902) Upgrade actions and remove deprecated set ouput commands (opensearch-project#2901) Update opensearch-2.4.0.yml (opensearch-project#2896) Resolve Window IntegTest copy and startup issues (opensearch-project#2892) Update IM ref to include fix (opensearch-project#2890) Fix manifest workflow failure (opensearch-project#2889) Install twine on clients image (opensearch-project#2884) Freeze the ref with commit ID (opensearch-project#2882) Add latest url update toggle on distribution workflows (opensearch-project#2881) Update promoteArtifacts to support win/zip and add timer for gradle check windows (opensearch-project#2869) Fix signing the artifacts for .asc signatures (opensearch-project#2850) Update the ref with 2.4 branch for OSD. (opensearch-project#2855) Update the OSD manifest with commit ID (opensearch-project#2862) Add gradle check support for windows agent (opensearch-project#2860) Add default copy for opensearch-dashboards yml and docker entrypoint (opensearch-project#2861) ... # Conflicts: # scripts/components/OpenSearch-Dashboards/install.sh
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Your Name you@example.com
Description
Resolve Window IntegTest copy and startup issues
Issues Resolved
#2649
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.