Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support RPM IntegTest runs on Jenkins #3285

Merged

Conversation

peterzhuamazon
Copy link
Member

Description

Support RPM IntegTest runs on Jenkins

Issues Resolved

#3198

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
@codecov-commenter
Copy link

codecov-commenter commented Mar 8, 2023

Codecov Report

Merging #3285 (eacea2b) into main (b87445e) will not change coverage.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff           @@
##             main    #3285   +/-   ##
=======================================
  Coverage   91.74%   91.74%           
=======================================
  Files         172      172           
  Lines        4991     4991           
=======================================
  Hits         4579     4579           
  Misses        412      412           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
jenkins/opensearch/integ-test.jenkinsfile Outdated Show resolved Hide resolved
jenkins/opensearch/integ-test.jenkinsfile Show resolved Hide resolved
jenkins/opensearch/integ-test.jenkinsfile Outdated Show resolved Hide resolved
Copy link
Member

@gaiksaya gaiksaya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add tests to make sure right docker images, args and agent_nodes are picked up for provided args?

Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
Copy link
Member

@zelinh zelinh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@peterzhuamazon peterzhuamazon merged commit eabc6da into opensearch-project:main Mar 10, 2023
@peterzhuamazon
Copy link
Member Author

Can we add tests to make sure right docker images, args and agent_nodes are picked up for provided args?

We will add it as a improvement soon.
Thanks.

@peterzhuamazon peterzhuamazon deleted the rpm-integ-test-jenkins branch March 10, 2023 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New Enhancement rpm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants