Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add github-merit-badger worflow #3305

Merged
merged 1 commit into from
Mar 14, 2023

Conversation

prudhvigodithi
Copy link
Member

Description

Adding the POC of github-merit-badger
The labels as part of badges are auto created.
Sample tested PR: prudhvigodithi#51

This github-merit-badger would give better insights to repo maintainers and would enhance the open source community experience.

Issues Resolved

List any issues this PR will resolve, e.g. Closes [...].

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@codecov-commenter
Copy link

codecov-commenter commented Mar 13, 2023

Codecov Report

Merging #3305 (b4e3a95) into main (eabc6da) will not change coverage.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff           @@
##             main    #3305   +/-   ##
=======================================
  Coverage   91.74%   91.74%           
=======================================
  Files         172      172           
  Lines        4991     4991           
=======================================
  Hits         4579     4579           
  Misses        412      412           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@prudhvigodithi prudhvigodithi force-pushed the main branch 2 times, most recently from bf52f19 to 73812ab Compare March 13, 2023 15:55
@prudhvigodithi
Copy link
Member Author

prudhvigodithi commented Mar 13, 2023

I'm open for discussing and changing the thresholds and badges.

badges: '[beginning-contributor,repeat-contributor,valued-contributor,admired-contributor,star-contributor,distinguished-contributor]'
thresholds: '[0,3,6,13,25,50]'

Terminology:
badges: Labels added to the PR.
thresholds: Based on number of PR's the badges (labels) are added.

Thank you

.github/workflows/github-merit-badger.yml Outdated Show resolved Hide resolved
.github/workflows/github-merit-badger.yml Show resolved Hide resolved
.github/workflows/github-merit-badger.yml Outdated Show resolved Hide resolved
.github/workflows/github-merit-badger.yml Show resolved Hide resolved
@prudhvigodithi
Copy link
Member Author

@bbarani @gaiksaya should we add days option? Like number of days the badge is valid?

Signed-off-by: Prudhvi Godithi <pgodithi@amazon.com>
@gaiksaya
Copy link
Member

@bbarani @gaiksaya should we add days option? Like number of days the badge is valid?

Can come as an enhancement. This looks good for now. Will see how this goes and how the community responds.

@prudhvigodithi
Copy link
Member Author

Can come as an enhancement. This looks good for now. Will see how this goes and how the community responds.

Thanks @gaiksaya if you are good, can you add your approval?

@prudhvigodithi prudhvigodithi merged commit 471eea2 into opensearch-project:main Mar 14, 2023
@CEHENKLE
Copy link
Member

Sorry, I'm late to the party -- are these values that can be set per repo? Or is it a project-wide thing?

I also like first-time (or maybe new) rather than beginner, but I'm fine with either :)

@prudhvigodithi
Copy link
Member Author

prudhvigodithi commented Mar 14, 2023

Hey @CEHENKLE yes it can be configured per repo or we can provider a set of guidelines for the entire org. Following are badge categories added to this repo.

first-time-contributor: 0
repeat-contributor: 3
valued-contributor: 6
seasoned-contributor: 13
all-star-contributor: 25
distinguished-contributor: 50

@CEHENKLE
Copy link
Member

Thanks! Can we add a set of defaults and let the repos override them?

/C

@prudhvigodithi
Copy link
Member Author

prudhvigodithi commented Mar 14, 2023

Thanks! Can we add a set of defaults and let the repos override them?

Yes @CEHENKLE that is possible, we can start a META issue with campaign and allow the repo teams to override the badge list. @bbarani @dblock

@CEHENKLE
Copy link
Member

super cool :)

@krisfreedain
Copy link
Member

this is awesome @prudhvigodithi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants