Update manifest with new security references #3986
Conversation
Signed-off-by: Stephen Crawford <steecraw@amazon.com>
Signed-off-by: Stephen Crawford <steecraw@amazon.com>
stephen-crawford
requested review from
dblock,
peterzhuamazon,
bbarani,
gaiksaya,
rishabh6788,
zelinh,
jordarlu,
prudhvigodithi,
Divyaasm and
tianleh
as code owners
Codecov Report
@@ Coverage Diff @@
## main #3986 +/- ##
=======================================
Coverage 92.06% 92.06%
=======================================
Files 187 187
Lines 5673 5673
=======================================
Hits 5223 5223
Misses 450 450 📢 Have feedback on the report? Share it here. |
| @@ -52,7 +52,7 @@ components: | |||
| - gradle:dependencies:opensearch.version | |||
| - name: security | |||
| repository: https://github.com/opensearch-project/security.git | |||
| ref: '2.10' | |||
| ref: tags/2.10.0.0 | |||
There was a problem hiding this comment.
tags cannot be added before the release. Same for another change
There was a problem hiding this comment.
We should remove this step from the "pre-release" section of the release instructions then: opensearch-project/security#3028 (comment).
The last item reads as updating the tags before the release. Perhaps this is not what is meant?
There was a problem hiding this comment.
Can you point me where it said tags? I see:
Update to the 2.10.0 release branch in the distribution manifest.
There was a problem hiding this comment.
I was referring to Add this repo to the [manifest](https://github.com/opensearch-project/opensearch-build/blob/main/manifests/) for the next developer iteration.
I am not sure what that means that is separate from the release branch update--so I figured it meant the tags.
There was a problem hiding this comment.
Next developer iteration is 2.11.0. So once you bump the version in 2.x branch, add your component to next manifest. The PR is still in review: #3969
There was a problem hiding this comment.
Gotcha, my misunderstanding.
Description
Update the manifest files with the new references for Security and Security dashboards repos.
Issues Resolved
(opensearch-project/security#3028)
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.