Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix opensearch-dashboards-functional-test version increment #4497

Merged
merged 1 commit into from
Mar 5, 2024

Conversation

prudhvigodithi
Copy link
Collaborator

@prudhvigodithi prudhvigodithi commented Mar 4, 2024

Description

Version increment for opensearch-dashboards-functional-test version started failing recently and looks to me some issue with the jq cli.

Old Command

jq --arg DASHBOARD_VERSION 2.13.0 '.version = 2.13.0' package.json > package-tmp.json
jq: error: Invalid numeric literal at EOF at line 1, column 6 (while parsing '2.13.0') at <top-level>, line 1:
.version = 2.13.0           
jq: 1 compile error

New command

jq --arg DASHBOARD_VERSION "$DASHBOARD_VERSION" '.version = $DASHBOARD_VERSION' package.json > package-tmp.json

Issues Resolved

Failing runs https://github.com/opensearch-project/opensearch-build/actions/runs/8134057241/job/22226466847

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Prudhvi Godithi <pgodithi@amazon.com>
Copy link

codecov bot commented Mar 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.19%. Comparing base (5779048) to head (bf6fb01).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4497   +/-   ##
=======================================
  Coverage   92.19%   92.19%           
=======================================
  Files         192      192           
  Lines        6292     6292           
=======================================
  Hits         5801     5801           
  Misses        491      491           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@prudhvigodithi prudhvigodithi merged commit 433c15d into opensearch-project:main Mar 5, 2024
13 checks passed
Divyaasm pushed a commit to Divyaasm/opensearch-build that referenced this pull request Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants