Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove mapping types #47

Closed
dreamer-89 opened this issue Mar 2, 2022 · 3 comments
Closed

Remove mapping types #47

dreamer-89 opened this issue Mar 2, 2022 · 3 comments
Labels
Breaking Changes A change in one part of a software system that causes other parts to fail enhancement v2.0.0

Comments

@dreamer-89
Copy link
Member

dreamer-89 commented Mar 2, 2022

As part of v2.0 release, mapping types are getting removed from OpenSearch engine. Below are the changes in the opensearch-engine.

  • Removal of type from rest end-points
  • Removal of include_type_name parameter from API requests.

As part of this issue, please verify if type removal change on OpenSearch engine impacts this repository. If yes, then please remove the type references/usage from this repository

Top level changes are captured in gist below:
https://gist.github.com/dreamer-89/d76eaf639171e8ab32fa7f8b9d6c93d3

For more detailed changes, please check meta issue below:
Related: OpenSearch-engine meta issue

@dreamer-89 dreamer-89 added enhancement Breaking Changes A change in one part of a software system that causes other parts to fail v2.0.0 labels Mar 2, 2022
@VijayanB
Copy link
Member

CLI doesn't use any rest endpoint which uses mapping type/include_type_name.

@dreamer-89
Copy link
Member Author

@VijayanB : Did you get a chance to go through all the changes captured in gist ? There are some changes in rest client, internal server classes which are used abundantly in other plugin repos.
https://gist.github.com/dreamer-89/d76eaf639171e8ab32fa7f8b9d6c93d3

@VijayanB
Copy link
Member

@VijayanB : Did you get a chance to go through all the changes captured in gist ? There are some changes in rest client, internal server classes which are used abundantly in other plugin repos. https://gist.github.com/dreamer-89/d76eaf639171e8ab32fa7f8b9d6c93d3

CLI accepts mapping as dynamic value from the user input. I added an integration test against OpenSearch 2.0. It didn't fail as expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Breaking Changes A change in one part of a software system that causes other parts to fail enhancement v2.0.0
Projects
None yet
Development

No branches or pull requests

2 participants