Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include integration testing against unreleased version #53

Merged
merged 4 commits into from
Apr 15, 2022

Conversation

VijayanB
Copy link
Member

Description

Include integration testing against unreleased version

Issues Resolved

#47

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has documentation added
  • Commits are signed as per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Change assert condition to be more generic
to support any distribution.

Signed-off-by: Vijayan Balasubramanian <balasvij@amazon.com>
Run integration test against unreleased opensearch version.

Signed-off-by: Vijayan Balasubramanian <balasvij@amazon.com>
Accept profile for insecure cluster as well.

Signed-off-by: Vijayan Balasubramanian <balasvij@amazon.com>
@VijayanB VijayanB requested a review from a team as a code owner April 15, 2022 01:21
java-version: ${{ matrix.java }}

- name: Checkout OpenSearch
uses: actions/checkout@v2
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actions/checkout@v3 is also available

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated

@codecov-commenter
Copy link

codecov-commenter commented Apr 15, 2022

Codecov Report

Merging #53 (5cf7842) into main (4e33131) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #53   +/-   ##
=======================================
  Coverage   67.26%   67.26%           
=======================================
  Files          31       31           
  Lines        1848     1848           
=======================================
  Hits         1243     1243           
  Misses        499      499           
  Partials      106      106           
Flag Coverage Δ
opensearch-cli 67.26% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Signed-off-by: Vijayan Balasubramanian <balasvij@amazon.com>
@VijayanB VijayanB requested a review from junqiu-lei April 15, 2022 01:45
@VijayanB VijayanB merged commit 1e1d66a into opensearch-project:main Apr 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants