Change the ec2 instance ami to AL2 #139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rishabh Singh <sngri@amazon.com>
rishabh6788
requested review from
peterzhuamazon,
gaiksaya,
zelinh,
prudhvigodithi and
Divyaasm
as code owners
gaiksaya
reviewed
Oct 23, 2024
gaiksaya
approved these changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We recently started seeing regression in our nightly benchmarks across all tracking OS versions, even for 2.17 which is GA since Sept-12.
So it couldn't be something changed on the OpenSearch side, since we use snapshot for data restore, it could not be corpus or index mapping getting changed, and I have OSB version also pinned to 1.8.0 for a few months, so it couldn't be something changed on OSB side.
After digging further I looked into underlying OS, which is AL2023 and it recently had new ami released (Oct-10).
I was looking at change logs but nothing jumped out of the ordinary. Just a few hours ago another user reported latency regression after switching to Al2023 and the root cause seems to be the OpenSSL library version. See amazonlinux/amazon-linux-2023#819 After going into the rabbit hole i found some other issues as well.
aws/aws-lambda-base-images#154
openssl/openssl#17064
This PR updates the ec2 instance ami to us AL2.
Issues Resolved
List any issues this PR will resolve, e.g. Closes [...].
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.