Scope discovery-ec2 IMDS lookups to this cluster formation. #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: dblock <dblock@amazon.com>
dblock
requested review from
peterzhuamazon,
bbarani,
gaiksaya,
rishabh6788,
zelinh,
jordarlu,
prudhvigodithi and
Divyaasm
as code owners
Codecov Report
@@ Coverage Diff @@
## main #36 +/- ##
==========================================
+ Coverage 79.71% 79.76% +0.05%
==========================================
Files 5 5
Lines 345 346 +1
Branches 104 104
==========================================
+ Hits 275 276 +1
Misses 70 70
|
rishabh6788
reviewed
Jun 8, 2023
| @@ -425,6 +425,10 @@ export class InfraStack extends Stack { | |||
| const baseConfig: any = load(readFileSync(`${configFileDir}/multi-node-base-config.yml`, 'utf-8')); | |||
|
|
|||
| baseConfig['cluster.name'] = `${scope.stackName}-${scope.account}-${scope.region}`; | |||
|
|
|||
| // use discovery-ec2 to find manager nodes by querying IMDS | |||
| baseConfig['discovery.ec2.tag.Name'] = `${scope.stackName}/seedNodeAsg,${scope.stackName}/managerNodeAsg`; | |||
There was a problem hiding this comment.
The same tag name should be associated with ec2 nodes as well, right?
https://github.com/opensearch-project/opensearch-cluster-cdk/blob/main/lib/infra/infra-stack.ts#L195
There was a problem hiding this comment.
It's already there. Here's what a node gets:
rishabh6788
approved these changes
Jun 8, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 24, 2023
Signed-off-by: dblock <dblock@amazon.com> (cherry picked from commit 7e7d6cf) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Scope discovery-ec2 IMDS lookups for seed/manager nodes down to this cluster. Here's a successful output.
I tried using
aws:cloudformation:stack-name, but OpenSearch doesn't support settings nameddiscovery.ec2.tag.aws:cloudformation:stack-name.Issues Resolved
Fixes #34.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.