-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] 1_create_datasource.spec.js fail due to multiple submit #439
Labels
bug
Something isn't working
Comments
This error is due to the below line of code in the test suite
There are two buttons have
Apparently, |
ananzh
added a commit
to ananzh/opensearch-dashboards-functional-test
that referenced
this issue
Jan 10, 2023
Currently there are two submit type button in data source which cause cypress fail to find and click. In this PR, I switch to use data-test-subj to uniquely identify the btn. Issue Resolved: opensearch-project#439 Signed-off-by: Anan Zhuang <ananzh@amazon.com>
ananzh
added a commit
to ananzh/opensearch-dashboards-functional-test
that referenced
this issue
Jan 11, 2023
Currently there are two submit type button in data source which cause cypress fail to find and click. In this PR, I switch to use data-test-subj to uniquely identify the btn. Issue Resolved: opensearch-project#439 Signed-off-by: Anan Zhuang <ananzh@amazon.com>
jakubp-eliatra
pushed a commit
to sebastianmichalski/opensearch-dashboards-functional-test
that referenced
this issue
Mar 24, 2023
Currently there are two submit type button in data source which cause cypress fail to find and click. In this PR, I switch to use data-test-subj to uniquely identify the btn. Issue Resolved: opensearch-project#439 Signed-off-by: Anan Zhuang <ananzh@amazon.com> Signed-off-by: Anan Zhuang <ananzh@amazon.com> Signed-off-by: Jakub Przybylski <jakub.przybylski@eliatra.com>
kavilla
pushed a commit
to ananzh/opensearch-dashboards-functional-test
that referenced
this issue
May 18, 2023
Currently there are two submit type button in data source which cause cypress fail to find and click. In this PR, I switch to use data-test-subj to uniquely identify the btn. Issue Resolved: opensearch-project#439 Signed-off-by: Anan Zhuang <ananzh@amazon.com>
kavilla
added a commit
that referenced
this issue
May 24, 2023
* [Table visualization] Add functional tests for new table vis There are four test cases: * basic.spec.js contains tests related to vis page, like inspector, save an object. * data.spec.js tests diff metrics and buckets aggregations. * options.spec.js contains tests on options panel. * split.spec.js tests table functions, like sort, adjust col width, split tables and etc. Most tests are the same as the removed funtional tests. split.spec.js is the only one with all new tests. Partially Resolved: #401 Signed-off-by: Anan Zhuang <ananzh@amazon.com> * fix PR comments Signed-off-by: Anan Zhuang <ananzh@amazon.com> * fix test error and add embed test suite Signed-off-by: Anan Zhuang <ananzh@amazon.com> * Fix multiple submit bug Currently there are two submit type button in data source which cause cypress fail to find and click. In this PR, I switch to use data-test-subj to uniquely identify the btn. Issue Resolved: #439 Signed-off-by: Anan Zhuang <ananzh@amazon.com> * missed conflict resolution Signed-off-by: Kawika Avilla <kavilla414@gmail.com> --------- Signed-off-by: Anan Zhuang <ananzh@amazon.com> Signed-off-by: Kawika Avilla <kavilla414@gmail.com> Co-authored-by: Kawika Avilla <kavilla414@gmail.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this issue
May 24, 2023
* [Table visualization] Add functional tests for new table vis There are four test cases: * basic.spec.js contains tests related to vis page, like inspector, save an object. * data.spec.js tests diff metrics and buckets aggregations. * options.spec.js contains tests on options panel. * split.spec.js tests table functions, like sort, adjust col width, split tables and etc. Most tests are the same as the removed funtional tests. split.spec.js is the only one with all new tests. Partially Resolved: #401 Signed-off-by: Anan Zhuang <ananzh@amazon.com> * fix PR comments Signed-off-by: Anan Zhuang <ananzh@amazon.com> * fix test error and add embed test suite Signed-off-by: Anan Zhuang <ananzh@amazon.com> * Fix multiple submit bug Currently there are two submit type button in data source which cause cypress fail to find and click. In this PR, I switch to use data-test-subj to uniquely identify the btn. Issue Resolved: #439 Signed-off-by: Anan Zhuang <ananzh@amazon.com> * missed conflict resolution Signed-off-by: Kawika Avilla <kavilla414@gmail.com> --------- Signed-off-by: Anan Zhuang <ananzh@amazon.com> Signed-off-by: Kawika Avilla <kavilla414@gmail.com> Co-authored-by: Kawika Avilla <kavilla414@gmail.com> (cherry picked from commit 3dffb5f)
opensearch-trigger-bot bot
pushed a commit
that referenced
this issue
May 24, 2023
* [Table visualization] Add functional tests for new table vis There are four test cases: * basic.spec.js contains tests related to vis page, like inspector, save an object. * data.spec.js tests diff metrics and buckets aggregations. * options.spec.js contains tests on options panel. * split.spec.js tests table functions, like sort, adjust col width, split tables and etc. Most tests are the same as the removed funtional tests. split.spec.js is the only one with all new tests. Partially Resolved: #401 Signed-off-by: Anan Zhuang <ananzh@amazon.com> * fix PR comments Signed-off-by: Anan Zhuang <ananzh@amazon.com> * fix test error and add embed test suite Signed-off-by: Anan Zhuang <ananzh@amazon.com> * Fix multiple submit bug Currently there are two submit type button in data source which cause cypress fail to find and click. In this PR, I switch to use data-test-subj to uniquely identify the btn. Issue Resolved: #439 Signed-off-by: Anan Zhuang <ananzh@amazon.com> * missed conflict resolution Signed-off-by: Kawika Avilla <kavilla414@gmail.com> --------- Signed-off-by: Anan Zhuang <ananzh@amazon.com> Signed-off-by: Kawika Avilla <kavilla414@gmail.com> Co-authored-by: Kawika Avilla <kavilla414@gmail.com> (cherry picked from commit 3dffb5f)
kavilla
pushed a commit
that referenced
this issue
May 24, 2023
…671) * [Table visualization] Add functional tests for new table vis There are four test cases: * basic.spec.js contains tests related to vis page, like inspector, save an object. * data.spec.js tests diff metrics and buckets aggregations. * options.spec.js contains tests on options panel. * split.spec.js tests table functions, like sort, adjust col width, split tables and etc. Most tests are the same as the removed funtional tests. split.spec.js is the only one with all new tests. Partially Resolved: #401 Signed-off-by: Anan Zhuang <ananzh@amazon.com> * fix PR comments Signed-off-by: Anan Zhuang <ananzh@amazon.com> * fix test error and add embed test suite Signed-off-by: Anan Zhuang <ananzh@amazon.com> * Fix multiple submit bug Currently there are two submit type button in data source which cause cypress fail to find and click. In this PR, I switch to use data-test-subj to uniquely identify the btn. Issue Resolved: #439 Signed-off-by: Anan Zhuang <ananzh@amazon.com> * missed conflict resolution Signed-off-by: Kawika Avilla <kavilla414@gmail.com> --------- Signed-off-by: Anan Zhuang <ananzh@amazon.com> Signed-off-by: Kawika Avilla <kavilla414@gmail.com> Co-authored-by: Kawika Avilla <kavilla414@gmail.com> (cherry picked from commit 3dffb5f) Co-authored-by: Anan Zhuang <ananzh@amazon.com>
peterzhuamazon
pushed a commit
that referenced
this issue
May 26, 2023
…672) * [Table visualization] Add functional tests for new table vis There are four test cases: * basic.spec.js contains tests related to vis page, like inspector, save an object. * data.spec.js tests diff metrics and buckets aggregations. * options.spec.js contains tests on options panel. * split.spec.js tests table functions, like sort, adjust col width, split tables and etc. Most tests are the same as the removed funtional tests. split.spec.js is the only one with all new tests. Partially Resolved: #401 Signed-off-by: Anan Zhuang <ananzh@amazon.com> * fix PR comments Signed-off-by: Anan Zhuang <ananzh@amazon.com> * fix test error and add embed test suite Signed-off-by: Anan Zhuang <ananzh@amazon.com> * Fix multiple submit bug Currently there are two submit type button in data source which cause cypress fail to find and click. In this PR, I switch to use data-test-subj to uniquely identify the btn. Issue Resolved: #439 Signed-off-by: Anan Zhuang <ananzh@amazon.com> * missed conflict resolution Signed-off-by: Kawika Avilla <kavilla414@gmail.com> --------- Signed-off-by: Anan Zhuang <ananzh@amazon.com> Signed-off-by: Kawika Avilla <kavilla414@gmail.com> Co-authored-by: Kawika Avilla <kavilla414@gmail.com> (cherry picked from commit 3dffb5f) Co-authored-by: Anan Zhuang <ananzh@amazon.com>
leanneeliatra
pushed a commit
to leanneeliatra/opensearch-dashboards-functional-test-fork
that referenced
this issue
Sep 15, 2023
…rch-project#423) (opensearch-project#671) * [Table visualization] Add functional tests for new table vis There are four test cases: * basic.spec.js contains tests related to vis page, like inspector, save an object. * data.spec.js tests diff metrics and buckets aggregations. * options.spec.js contains tests on options panel. * split.spec.js tests table functions, like sort, adjust col width, split tables and etc. Most tests are the same as the removed funtional tests. split.spec.js is the only one with all new tests. Partially Resolved: opensearch-project#401 Signed-off-by: Anan Zhuang <ananzh@amazon.com> * fix PR comments Signed-off-by: Anan Zhuang <ananzh@amazon.com> * fix test error and add embed test suite Signed-off-by: Anan Zhuang <ananzh@amazon.com> * Fix multiple submit bug Currently there are two submit type button in data source which cause cypress fail to find and click. In this PR, I switch to use data-test-subj to uniquely identify the btn. Issue Resolved: opensearch-project#439 Signed-off-by: Anan Zhuang <ananzh@amazon.com> * missed conflict resolution Signed-off-by: Kawika Avilla <kavilla414@gmail.com> --------- Signed-off-by: Anan Zhuang <ananzh@amazon.com> Signed-off-by: Kawika Avilla <kavilla414@gmail.com> Co-authored-by: Kawika Avilla <kavilla414@gmail.com> (cherry picked from commit 3dffb5f) Co-authored-by: Anan Zhuang <ananzh@amazon.com> Signed-off-by: leanne.laceybyrne@eliatra.com <leanne.laceybyrne@eliatra.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What is the bug?
Currently,
1_create_datasource.spec.js
test suite fails due to multiple submit element found in the test. Details error log is pasted below:How can one reproduce the bug?
Just check recent submitted PRs or run this test.
What is the expected behavior?
Fix the bug
The text was updated successfully, but these errors were encountered: