Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] [2.12] Update security analytics tests #1086

Merged
merged 1 commit into from
Feb 26, 2024

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 14400ed from #1085

@SuZhou-Joe
Copy link
Member

Security analytics related test failed, @amsiglan could you please explain why?

@amsiglan
Copy link
Contributor

amsiglan commented Feb 17, 2024

Security analytics related test failed, @amsiglan could you please explain why?

From the logs it seems like the backend is not setup correctly since we see 404 for the first api call we are making -

http://localhost:5601/_plugins/_security_analytics/rules?category=dns

The response we received from your web server was:

  > 404: Not Found

Also, we have all the tests passing locally and even with the tests that ran during RC generation for 2.12 (except for 1 flaky test that was fixed in different PR). @SuZhou-Joe Could you or someone from the team help figure out why the 404s happened? I have seen this security-analytics for past few PRs and one theory was that maybe the backend plugin is not loading correctly

@SuZhou-Joe
Copy link
Member

@amsiglan Sure, will take a look.

@SuZhou-Joe
Copy link
Member

@amsiglan /_plugins/_security_analytics this API seems like a backend API, and I tried to call it from my local env it response successfully.

* updated tests

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

* updated tests

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

* updated tests

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

* updated intercepts

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

* fixed lint errors

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

* updated tests

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

* fixed incorrect intercept setup

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

* updated rules test

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

---------

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
(cherry picked from commit 14400ed)
@SuZhou-Joe SuZhou-Joe merged commit 76e0d16 into 2.x Feb 26, 2024
41 of 43 checks passed
@github-actions github-actions bot deleted the backport/backport-1085-to-2.x branch February 26, 2024 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants