Restore video recording on Windows with DISABLE_VIDEO parameter #1142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
peterzhuamazon
added
enhancement
peterzhuamazon
requested review from
xluo-aws,
Hailong-am,
SuZhou-Joe,
ruanyl,
wanglam and
raintygao
as code owners
|
Since these 2PRs Windows now fully support ffmpeg, thus we can re-enable this feature and introduce a param for user to disable it if needed.
Thanks. |
Hailong-am
approved these changes
Mar 13, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Apr 9, 2024
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> (cherry picked from commit 1a04ae2)
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Apr 9, 2024
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> (cherry picked from commit 1a04ae2)
peterzhuamazon
added a commit
that referenced
this pull request
Apr 9, 2024
peterzhuamazon
added a commit
that referenced
this pull request
Apr 9, 2024
This was referenced Apr 15, 2024
LDrago27
pushed a commit
to LDrago27/opensearch-dashboards-functional-test
that referenced
this pull request
May 3, 2024
…search-project#1142) Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Restore video recording on Windows with DISABLE_VIDEO parameter
Issues Resolved
Closes opensearch-project/opensearch-build#4427
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.