-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Cypress test for Default Saved Map #552
Add Cypress test for Default Saved Map #552
Conversation
Signed-off-by: Naveen Tatikonda <navtat@amazon.com>
ddfd10e
to
955a028
Compare
Can you do me a favor in seperate PR can you add your test to the test results explorer site for easier debugging in the future: |
cypress/integration/plugins/custom-import-map-dashboards/add_saved_object.spec.js
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My suggestion as well is add a number before the file to ensure the order.
I believe for dashboards-maps tests order doesn't matter because they are all running independently. But, if you want to follow that naming convention then I will create a separate PR renaming the tests in dashboards-maps |
Signed-off-by: Naveen Tatikonda <navtat@amazon.com>
With hindsight, I've seen developers get test failures. For scalability when more developers contribute they might assume that a specific test will always come before another test and write tests in such a fashion (which isn't great but not preventable) but then they add a new file and since cypress will run in alpha-numeric order and failures occur. So adding a number ensures tests run in a specific order. |
Got it. Will raise a separate PR renaming all dashboards-maps tests by adding numbers after merging this PR. |
forgot to mention you need to add your path to your tests and your plugin id: https://github.com/opensearch-project/opensearch-dashboards-functional-test/blob/main/test_finder.sh#L10 |
Hi @kavilla, the layered maps App is still under custom-import-map-dashboards plugin. I don't think we need change here. https://github.com/opensearch-project/opensearch-dashboards-functional-test/blob/main/test_finder.sh#L20 |
whoops missed it! thank you sorry about that |
is the goal is to get this to 2.x branch? |
Yes, actually to 2.6 |
* Add Cypress test for Default Saved Map Signed-off-by: Naveen Tatikonda <navtat@amazon.com> * Address Review Comments Signed-off-by: Naveen Tatikonda <navtat@amazon.com> --------- Signed-off-by: Naveen Tatikonda <navtat@amazon.com> (cherry picked from commit 61766e7)
* Add Cypress test for Default Saved Map Signed-off-by: Naveen Tatikonda <navtat@amazon.com> * Address Review Comments Signed-off-by: Naveen Tatikonda <navtat@amazon.com> --------- Signed-off-by: Naveen Tatikonda <navtat@amazon.com> (cherry picked from commit 61766e7)
* Add Cypress test for Default Saved Map Signed-off-by: Naveen Tatikonda <navtat@amazon.com> * Address Review Comments Signed-off-by: Naveen Tatikonda <navtat@amazon.com> --------- Signed-off-by: Naveen Tatikonda <navtat@amazon.com> (cherry picked from commit 61766e7)
* Add Cypress test for Default Saved Map Signed-off-by: Naveen Tatikonda <navtat@amazon.com> * Address Review Comments Signed-off-by: Naveen Tatikonda <navtat@amazon.com> --------- Signed-off-by: Naveen Tatikonda <navtat@amazon.com> (cherry picked from commit 61766e7) Co-authored-by: Naveen Tatikonda <navtat@amazon.com>
* Add Cypress test for Default Saved Map Signed-off-by: Naveen Tatikonda <navtat@amazon.com> * Address Review Comments Signed-off-by: Naveen Tatikonda <navtat@amazon.com> --------- Signed-off-by: Naveen Tatikonda <navtat@amazon.com> (cherry picked from commit 61766e7) Co-authored-by: Naveen Tatikonda <navtat@amazon.com>
* Add Cypress test for Default Saved Map Signed-off-by: Naveen Tatikonda <navtat@amazon.com> * Address Review Comments Signed-off-by: Naveen Tatikonda <navtat@amazon.com> --------- Signed-off-by: Naveen Tatikonda <navtat@amazon.com> (cherry picked from commit 61766e7) Co-authored-by: Naveen Tatikonda <navtat@amazon.com>
…search-project#632) * Add Cypress test for Default Saved Map Signed-off-by: Naveen Tatikonda <navtat@amazon.com> * Address Review Comments Signed-off-by: Naveen Tatikonda <navtat@amazon.com> --------- Signed-off-by: Naveen Tatikonda <navtat@amazon.com> (cherry picked from commit 61766e7) Co-authored-by: Naveen Tatikonda <navtat@amazon.com> Signed-off-by: leanne.laceybyrne@eliatra.com <leanne.laceybyrne@eliatra.com>
Description
Add Cypress test to validate adding default saved map for the sample flights dataset in the dashboards-maps plugin.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.