Add Cypress test for Default Saved Map

[naveentatikonda]

Description

Add Cypress test to validate adding default saved map for the sample flights dataset in the dashboards-maps plugin.

Check List

• Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[kavilla]

Can you do me a favor in seperate PR can you add your test to the test results explorer site for easier debugging in the future:

• https://github.com/opensearch-project/opensearch-dashboards-functional-test/blob/main/site/js/dashboard.js#L16
• https://github.com/opensearch-project/opensearch-dashboards-functional-test/blob/main/site/index.html#L134

[kavilla]

My suggestion as well is add a number before the file to ensure the order.

[naveentatikonda]

My suggestion as well is add a number before the file to ensure the order.

I believe for dashboards-maps tests order doesn't matter because they are all running independently. But, if you want to follow that naming convention then I will create a separate PR renaming the tests in dashboards-maps

[kavilla]

My suggestion as well is add a number before the file to ensure the order.

I believe for dashboards-maps tests order doesn't matter because they are all running independently. But, if you want to follow that naming convention then I will create a separate PR renaming the tests in dashboards-maps

With hindsight, I've seen developers get test failures. For scalability when more developers contribute they might assume that a specific test will always come before another test and write tests in such a fashion (which isn't great but not preventable) but then they add a new file and since cypress will run in alpha-numeric order and failures occur. So adding a number ensures tests run in a specific order.

[naveentatikonda]

My suggestion as well is add a number before the file to ensure the order.

I believe for dashboards-maps tests order doesn't matter because they are all running independently. But, if you want to follow that naming convention then I will create a separate PR renaming the tests in dashboards-maps

With hindsight, I've seen developers get test failures. For scalability when more developers contribute they might assume that a specific test will always come before another test and write tests in such a fashion (which isn't great but not preventable) but then they add a new file and since cypress will run in alpha-numeric order and failures occur. So adding a number ensures tests run in a specific order.

Got it. Will raise a separate PR renaming all dashboards-maps tests by adding numbers after merging this PR.

[kavilla]

forgot to mention you need to add your path to your tests and your plugin id: https://github.com/opensearch-project/opensearch-dashboards-functional-test/blob/main/test_finder.sh#L10

[junqiu-lei]

forgot to mention you need to add your path to your tests and your plugin id: https://github.com/opensearch-project/opensearch-dashboards-functional-test/blob/main/test_finder.sh#L10

Hi @kavilla, the layered maps App is still under custom-import-map-dashboards plugin. I don't think we need change here. https://github.com/opensearch-project/opensearch-dashboards-functional-test/blob/main/test_finder.sh#L20

[kavilla]

forgot to mention you need to add your path to your tests and your plugin id: https://github.com/opensearch-project/opensearch-dashboards-functional-test/blob/main/test_finder.sh#L10

Hi @kavilla, the layered maps App is still under custom-import-map-dashboards plugin. I don't think we need change here. https://github.com/opensearch-project/opensearch-dashboards-functional-test/blob/main/test_finder.sh#L20

whoops missed it! thank you sorry about that

[kavilla]

is the goal is to get this to 2.x branch?

[naveentatikonda]

is the goal is to get this to 2.x branch?

Yes, actually to 2.6