Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Observability panel and trace tests #641

Merged
merged 2 commits into from
Apr 21, 2023
Merged

Update Observability panel and trace tests #641

merged 2 commits into from
Apr 21, 2023

Conversation

mengweieric
Copy link
Contributor

@mengweieric mengweieric commented Apr 20, 2023 •
edited
Loading

Description

  • Update panel tests
  • Update trace tests

This needs to be backported to 2.7 and 2.x.

Issues Resolved

[List any issues this PR will resolve]

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@mengweieric
updated panel tests
820c25e 
Signed-off-by: Eric Wei <menwe@amazon.com>
@mengweieric
update obs trace tests
920a136 
Signed-off-by: Eric Wei <menwe@amazon.com>
@mengweieric
Copy link
Contributor Author 

     Spec                                              Tests  Passing  Failing  Pending  Skipped  
  ┌────────────────────────────────────────────────────────────────────────────────────────────────┐
  │ ✔  plugins/observability-dashboards/0_      00:13        1        1        -        -        - │
  │    before.spec.js                                                                              │
  ├────────────────────────────────────────────────────────────────────────────────────────────────┤
  │ ✔  plugins/observability-dashboards/1_      01:16        7        7        -        -        - │
  │    trace_analytics_dashboard.spec.js                                                           │
  ├────────────────────────────────────────────────────────────────────────────────────────────────┤
  │ ✔  plugins/observability-dashboards/2_      00:33        5        5        -        -        - │
  │    trace_analytics_services.spec.js                                                            │
  ├────────────────────────────────────────────────────────────────────────────────────────────────┤
  │ ✔  plugins/observability-dashboards/3_      00:26        4        4        -        -        - │
  │    trace_analytics_traces.spec.js                                                              │
  ├────────────────────────────────────────────────────────────────────────────────────────────────┤
  │ ✔  plugins/observability-dashboards/4_      00:59        7        7        -        -        - │
  │    panels.spec.js                                                                              │
  ├────────────────────────────────────────────────────────────────────────────────────────────────┤
  │ ✔  plugins/observability-dashboards/5_      01:11        4        4        -        -        - │
  │    event_analytics.spec.js                                                                     │
  ├────────────────────────────────────────────────────────────────────────────────────────────────┤
  │ ✔  plugins/observability-dashboards/6_      03:30       16       16        -        -        - │
  │    notebooks.spec.js                                                                           │
  ├────────────────────────────────────────────────────────────────────────────────────────────────┤
  │ ✔  plugins/observability-dashboards/7_      01:33        1        1        -        -        - │
  │    app_analytics.spec.js                                                                       │
  ├────────────────────────────────────────────────────────────────────────────────────────────────┤
  │ ✔  plugins/observability-dashboards/8_      183ms        1        1        -        -        - │
  │    after.spec.js                                                                               │
  └────────────────────────────────────────────────────────────────────────────────────────────────┘
    ✔  All specs passed!                        09:46       46       46        -        -        -

@mengweieric
Copy link
Contributor Author

mengweieric commented Apr 20, 2023 •
edited
Loading

These are the changes required for 2.7, could you help on merging this and backport to 2.7 and 2.x? thanks! @tianleh @kavilla @ashwin-pc @peterzhuamazon @ohltyler @CCongWang

@tianleh tianleh merged commit 9e838bb into opensearch-project:main Apr 21, 2023
opensearch-trigger-bot bot pushed a commit that referenced this pull request Apr 21, 2023
@mengweieric @github-actions
Update Observability panel and trace tests (#641)
ab2a8e3 
* updated panel tests

Signed-off-by: Eric Wei <menwe@amazon.com>

* update obs trace tests

Signed-off-by: Eric Wei <menwe@amazon.com>

---------

Signed-off-by: Eric Wei <menwe@amazon.com>
(cherry picked from commit 9e838bb)
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Apr 21, 2023
Merged
opensearch-trigger-bot bot pushed a commit that referenced this pull request Apr 21, 2023
@mengweieric @github-actions
Update Observability panel and trace tests (#641)
07cae3d 
* updated panel tests

Signed-off-by: Eric Wei <menwe@amazon.com>

* update obs trace tests

Signed-off-by: Eric Wei <menwe@amazon.com>

---------

Signed-off-by: Eric Wei <menwe@amazon.com>
(cherry picked from commit 9e838bb)
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Apr 21, 2023
Merged
@mengweieric mengweieric deleted the feature/update-obs-panel-trace-tests branch April 21, 2023 00:04
kavilla pushed a commit that referenced this pull request Apr 21, 2023
@opensearch-trigger-bot @mengweieric
Update Observability panel and trace tests (#641) (#643)
be53407 
* updated panel tests

Signed-off-by: Eric Wei <menwe@amazon.com>

* update obs trace tests

Signed-off-by: Eric Wei <menwe@amazon.com>

---------

Signed-off-by: Eric Wei <menwe@amazon.com>
(cherry picked from commit 9e838bb)

Co-authored-by: Eric Wei <menwe@amazon.com>
kavilla pushed a commit that referenced this pull request Apr 21, 2023
@opensearch-trigger-bot @mengweieric
Update Observability panel and trace tests (#641) (#642)
3a1b00f 
* updated panel tests

Signed-off-by: Eric Wei <menwe@amazon.com>

* update obs trace tests

Signed-off-by: Eric Wei <menwe@amazon.com>

---------

Signed-off-by: Eric Wei <menwe@amazon.com>
(cherry picked from commit 9e838bb)

Co-authored-by: Eric Wei <menwe@amazon.com>
leanneeliatra pushed a commit to leanneeliatra/opensearch-dashboards-functional-test-fork that referenced this pull request Sep 15, 2023
@opensearch-trigger-bot @mengweieric @leanneeliatra
Update Observability panel and trace tests (opensearch-project#641) (o…
835da00 
…pensearch-project#642)

* updated panel tests

Signed-off-by: Eric Wei <menwe@amazon.com>

* update obs trace tests

Signed-off-by: Eric Wei <menwe@amazon.com>

---------

Signed-off-by: Eric Wei <menwe@amazon.com>
(cherry picked from commit 9e838bb)

Co-authored-by: Eric Wei <menwe@amazon.com>
Signed-off-by: leanne.laceybyrne@eliatra.com <leanne.laceybyrne@eliatra.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kavilla kavilla kavilla approved these changes

@tianleh tianleh tianleh approved these changes

@ohltyler ohltyler Awaiting requested review from ohltyler ohltyler is a code owner

@CCongWang CCongWang Awaiting requested review from CCongWang CCongWang is a code owner

@ashwin-pc ashwin-pc Awaiting requested review from ashwin-pc ashwin-pc is a code owner

@peterzhuamazon peterzhuamazon Awaiting requested review from peterzhuamazon peterzhuamazon is a code owner

Assignees
No one assigned
Labels
backport 2.x backport 2.7 v2.7.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mengweieric @kavilla @tianleh