Update table vis test in dashboard_filtering_spec.js #682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue Resolve opensearch-project#681 Signed-off-by: Anan Zhuang <ananzh@amazon.com>
ananzh
requested review from
tianleh,
kavilla,
ohltyler,
CCongWang,
ashwin-pc and
peterzhuamazon
as code owners
1 task
kavilla
approved these changes
May 26, 2023
|
I will fix the rebase of @ananzh branch if you are ok, thanks. |
|
Awaiting: |
|
The failure now is related to a different problem that OS or OSD not started. Can merge. |
peterzhuamazon
approved these changes
May 26, 2023
peterzhuamazon
pushed a commit
that referenced
this pull request
May 26, 2023
leanneeliatra
pushed a commit
to leanneeliatra/opensearch-dashboards-functional-test-fork
that referenced
this pull request
Sep 15, 2023
…ect#682) (opensearch-project#691) Issue Resolve opensearch-project#681 Signed-off-by: Anan Zhuang <ananzh@amazon.com> Co-authored-by: Peter Zhu <zhujiaxi@amazon.com> (cherry picked from commit f3768f8) Co-authored-by: Anan Zhuang <ananzh@amazon.com> Signed-off-by: leanne.laceybyrne@eliatra.com <leanne.laceybyrne@eliatra.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
table test fails when running dashboard_filtering_spec.js due to updates on the table vis. This PR modified the mappings and updates the tests. Meanwhile
commonUI.setDateRangeis not very stable. Always see failure. Switch it to a more stable function.Issues Resolved
#681
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.