-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Read-only tenant mode tests #792
Read-only tenant mode tests #792
Conversation
Signed-off-by: Kajetan Nobel <k.nobel@routegroup.pl>
cypress/integration/plugins/security-dashboards-plugin/readonly.js
Outdated
Show resolved
Hide resolved
Signed-off-by: Kajetan Nobel <k.nobel@routegroup.pl>
db1115a
to
fced5cb
Compare
FYI: I've tested it with the versions:
Because of that, I'm labeling it as a draft until the issue will be resolved. |
Signed-off-by: Kajetan Nobel <k.nobel@routegroup.pl>
A fix for 2.9.0 has been introduced |
Signed-off-by: Kajetan Nobel <kajetan.nobel@eliatra.com>
Signed-off-by: Kajetan Nobel <kajetan.nobel@eliatra.com>
Signed-off-by: Kajetan Nobel <kajetan.nobel@eliatra.com>
@SuZhou-Joe @ruanyl I've retested it with 2.11.1 and also improved tests. Please check one more time :) |
@kajetan-nobel need to backport 2.x? |
@SuZhou-Joe thanks! I think yes, as the main parts are already backported. |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-792-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 941f2defd6bc133c5796d37e7593f99c345f343c
# Push it to GitHub
git push --set-upstream origin backport/backport-792-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x Then, create a pull request where the |
@kajetan-nobel Backport failed, could you please manually backport to 2.x and raise a PR based on the instructions provided above? |
* feat: introduces read-only tenant mode tests Signed-off-by: Kajetan Nobel <k.nobel@routegroup.pl> * feat: move loadSampleData to before Signed-off-by: Kajetan Nobel <k.nobel@routegroup.pl> * fix: add data to correct tenant, fix for version 2.9.0 Signed-off-by: Kajetan Nobel <k.nobel@routegroup.pl> * feat: retest and improve switching tenant Signed-off-by: Kajetan Nobel <kajetan.nobel@eliatra.com> --------- Signed-off-by: Kajetan Nobel <k.nobel@routegroup.pl> Signed-off-by: Kajetan Nobel <kajetan.nobel@eliatra.com> (cherry picked from commit 941f2de)
* feat: introduces read-only tenant mode tests Signed-off-by: Kajetan Nobel <k.nobel@routegroup.pl> * feat: move loadSampleData to before Signed-off-by: Kajetan Nobel <k.nobel@routegroup.pl> * fix: add data to correct tenant, fix for version 2.9.0 Signed-off-by: Kajetan Nobel <k.nobel@routegroup.pl> * feat: retest and improve switching tenant Signed-off-by: Kajetan Nobel <kajetan.nobel@eliatra.com> --------- Signed-off-by: Kajetan Nobel <k.nobel@routegroup.pl> Signed-off-by: Kajetan Nobel <kajetan.nobel@eliatra.com> (cherry picked from commit 941f2de)
Description
Introduces tests for read-only tenant mode.
Issues Resolved
This is a complementary PR for:
opensearch-project/OpenSearch-Dashboards#4498
opensearch-project/security-dashboards-plugin#1472
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.