Add tests for data source selector #965
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Eric <menwe@amazon.com>
mengweieric
requested review from
xluo-aws,
Hailong-am,
SuZhou-Joe,
ruanyl,
wanglam and
raintygao
as code owners
7 tasks
kavilla
reviewed
Nov 28, 2023
...-opensearch-dashboards/opensearch-dashboards/apps/data_explorer/data_source_selector.spec.js
Show resolved
Hide resolved
|
Mind adding this https://github.com/opensearch-project/opensearch-dashboards-functional-test/blob/main/package.json#L35 to make it a little bit faster to run. |
Signed-off-by: Eric <menwe@amazon.com>
Signed-off-by: Eric <menwe@amazon.com>
ashwin-pc
approved these changes
Nov 29, 2023
|
@mengweieric should this backport to 2.x? |
yes, please add backport 2.x label thanks |
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jan 30, 2024
* add tests for data source selector Signed-off-by: Eric <menwe@amazon.com> * add global tenant Signed-off-by: Eric <menwe@amazon.com> * add to ciGroup Signed-off-by: Eric <menwe@amazon.com> --------- Signed-off-by: Eric <menwe@amazon.com> (cherry picked from commit 26ab107)
|
For these tests, are they written in such a way that they would have detected the malfunctions reported here: opensearch-project/OpenSearch-Dashboards#5609 |
ruanyl
pushed a commit
that referenced
this pull request
Feb 7, 2024
* add tests for data source selector Signed-off-by: Eric <menwe@amazon.com> * add global tenant Signed-off-by: Eric <menwe@amazon.com> * add to ciGroup Signed-off-by: Eric <menwe@amazon.com> --------- Signed-off-by: Eric <menwe@amazon.com> (cherry picked from commit 26ab107) Co-authored-by: Eric Wei <menwe@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add e2e tests for data source selector.
Issues Resolved
Following up on #5211
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.