Add text embedding processor #1007
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miguel-vila
requested review from
reta,
Bukhtawar,
dblock,
szczepanczykd,
madhusudhankonda,
saratvemulapalli and
VachaShah
as code owners
miguel-vila
force-pushed
the
add-text-embedding-processor
branch
from
790c470
to
fa790af
Compare
Signed-off-by: miguel-vila <miguelvilag@gmail.com>
Signed-off-by: miguel-vila <miguelvilag@gmail.com>
miguel-vila
force-pushed
the
add-text-embedding-processor
branch
from
aa753b3
to
90f78e4
Compare
dblock
requested changes
Jun 3, 2024
reta
reviewed
Jun 3, 2024
| * compatible open source license. | ||
| */ | ||
|
|
||
| /* |
There was a problem hiding this comment.
Sorry was this class copied for Elasticsearch codebase? If not, we could only keep SPDX License
There was a problem hiding this comment.
yeah, probably something I copied and pasted from another processor class, fixed at: 752df7b
Signed-off-by: miguel-vila <miguelvilag@gmail.com>
Signed-off-by: miguel-vila <miguelvilag@gmail.com>
Signed-off-by: miguel-vila <miguelvilag@gmail.com>
dblock
approved these changes
Jun 3, 2024
|
@reta LGTM |
reta
approved these changes
Jun 3, 2024
reta
added
backport 2.x
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jun 3, 2024
* Add text embedding processor Signed-off-by: miguel-vila <miguelvilag@gmail.com> * add changelog entry Signed-off-by: miguel-vila <miguelvilag@gmail.com> * add (de)serialization test Signed-off-by: miguel-vila <miguelvilag@gmail.com> * fix files headers Signed-off-by: miguel-vila <miguelvilag@gmail.com> * fix for java 8 Signed-off-by: miguel-vila <miguelvilag@gmail.com> --------- Signed-off-by: miguel-vila <miguelvilag@gmail.com> (cherry picked from commit 5b90848) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
reta
pushed a commit
that referenced
this pull request
Jun 3, 2024
* Add text embedding processor * add changelog entry * add (de)serialization test * fix files headers * fix for java 8 --------- (cherry picked from commit 5b90848) Signed-off-by: miguel-vila <miguelvilag@gmail.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds the text embedding processor: https://opensearch.org/docs/latest/ingest-pipelines/processors/text-embedding/
Issues Resolved
Should close #1005
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.