Fix copy-paste mistake in NeuralSearch sample #1161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Thomas Farr <tsfarr@amazon.com>
Xtansia
requested review from
reta,
Bukhtawar,
dblock,
szczepanczykd,
madhusudhankonda,
saratvemulapalli and
VachaShah
as code owners
reta
approved these changes
Aug 26, 2024
alex-keeler
pushed a commit
to alex-keeler/opensearch-java
that referenced
this pull request
Aug 29, 2024
Signed-off-by: Thomas Farr <tsfarr@amazon.com> Signed-off-by: Alex Keeler <akeeler4227@gmail.com>
Xtansia
added a commit
that referenced
this pull request
Oct 22, 2024
* Generate the ml namespace (#1158) * Generate ml.register_model_group Signed-off-by: Thomas Farr <tsfarr@amazon.com> * Start neural search sample Signed-off-by: Thomas Farr <tsfarr@amazon.com> * Re-generate ShardStatistics Signed-off-by: Thomas Farr <tsfarr@amazon.com> * Re-generate ShardFailure Signed-off-by: Thomas Farr <tsfarr@amazon.com> * Re-generate Result Signed-off-by: Thomas Farr <tsfarr@amazon.com> * Re-generate WriteResponseBase Signed-off-by: Thomas Farr <tsfarr@amazon.com> * Generate ml.delete_model_group Signed-off-by: Thomas Farr <tsfarr@amazon.com> * Generate ml.register_model Signed-off-by: Thomas Farr <tsfarr@amazon.com> * Exclude legacy license from ml namespace Signed-off-by: Thomas Farr <tsfarr@amazon.com> * Generate ml.get_task Signed-off-by: Thomas Farr <tsfarr@amazon.com> * Generate ml.delete_task Signed-off-by: Thomas Farr <tsfarr@amazon.com> * Generate ml.delete_model Signed-off-by: Thomas Farr <tsfarr@amazon.com> * Generate ml.deploy_model Signed-off-by: Thomas Farr <tsfarr@amazon.com> * Generate ml.undeploy_model Signed-off-by: Thomas Farr <tsfarr@amazon.com> * Complete neural search sample Signed-off-by: Thomas Farr <tsfarr@amazon.com> * Generate ml.get_model Signed-off-by: Thomas Farr <tsfarr@amazon.com> * Add changelog entry Signed-off-by: Thomas Farr <tsfarr@amazon.com> * note Signed-off-by: Thomas Farr <tsfarr@amazon.com> * Fix tests Signed-off-by: Thomas Farr <tsfarr@amazon.com> --------- Signed-off-by: Thomas Farr <tsfarr@amazon.com> Signed-off-by: Alex Keeler <akeeler4227@gmail.com> * Fix copy-paste mistake in NeuralSearch sample (#1161) Signed-off-by: Thomas Farr <tsfarr@amazon.com> Signed-off-by: Alex Keeler <akeeler4227@gmail.com> * Support Radial Search Add minScore, maxDistance parameters to KnnQuery in order to support Radial Search, which was introduced in OpenSearch 2.14 https://opensearch.org/docs/latest/search-plugins/knn/radial-search-knn/ Signed-off-by: Alex Keeler <akeeler4227@gmail.com> * Update CHANGELOG.md Signed-off-by: alex-keeler <59743435+alex-keeler@users.noreply.github.com> Signed-off-by: Alex Keeler <akeeler4227@gmail.com> * Update changelog post releasing 2.14.0 (#1162) (#1167) Signed-off-by: Thomas Farr <tsfarr@amazon.com> (cherry picked from commit 2a362a6) * Reduce required release approvals (#1168) Signed-off-by: Thomas Farr <tsfarr@amazon.com> Signed-off-by: Alex Keeler <akeeler4227@gmail.com> --------- Signed-off-by: Thomas Farr <tsfarr@amazon.com> Signed-off-by: Alex Keeler <akeeler4227@gmail.com> Signed-off-by: alex-keeler <59743435+alex-keeler@users.noreply.github.com> Co-authored-by: Thomas Farr <tsfarr@amazon.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 22, 2024
* Generate the ml namespace (#1158) * Generate ml.register_model_group Signed-off-by: Thomas Farr <tsfarr@amazon.com> * Start neural search sample Signed-off-by: Thomas Farr <tsfarr@amazon.com> * Re-generate ShardStatistics Signed-off-by: Thomas Farr <tsfarr@amazon.com> * Re-generate ShardFailure Signed-off-by: Thomas Farr <tsfarr@amazon.com> * Re-generate Result Signed-off-by: Thomas Farr <tsfarr@amazon.com> * Re-generate WriteResponseBase Signed-off-by: Thomas Farr <tsfarr@amazon.com> * Generate ml.delete_model_group Signed-off-by: Thomas Farr <tsfarr@amazon.com> * Generate ml.register_model Signed-off-by: Thomas Farr <tsfarr@amazon.com> * Exclude legacy license from ml namespace Signed-off-by: Thomas Farr <tsfarr@amazon.com> * Generate ml.get_task Signed-off-by: Thomas Farr <tsfarr@amazon.com> * Generate ml.delete_task Signed-off-by: Thomas Farr <tsfarr@amazon.com> * Generate ml.delete_model Signed-off-by: Thomas Farr <tsfarr@amazon.com> * Generate ml.deploy_model Signed-off-by: Thomas Farr <tsfarr@amazon.com> * Generate ml.undeploy_model Signed-off-by: Thomas Farr <tsfarr@amazon.com> * Complete neural search sample Signed-off-by: Thomas Farr <tsfarr@amazon.com> * Generate ml.get_model Signed-off-by: Thomas Farr <tsfarr@amazon.com> * Add changelog entry Signed-off-by: Thomas Farr <tsfarr@amazon.com> * note Signed-off-by: Thomas Farr <tsfarr@amazon.com> * Fix tests Signed-off-by: Thomas Farr <tsfarr@amazon.com> --------- Signed-off-by: Thomas Farr <tsfarr@amazon.com> Signed-off-by: Alex Keeler <akeeler4227@gmail.com> * Fix copy-paste mistake in NeuralSearch sample (#1161) Signed-off-by: Thomas Farr <tsfarr@amazon.com> Signed-off-by: Alex Keeler <akeeler4227@gmail.com> * Support Radial Search Add minScore, maxDistance parameters to KnnQuery in order to support Radial Search, which was introduced in OpenSearch 2.14 https://opensearch.org/docs/latest/search-plugins/knn/radial-search-knn/ Signed-off-by: Alex Keeler <akeeler4227@gmail.com> * Update CHANGELOG.md Signed-off-by: alex-keeler <59743435+alex-keeler@users.noreply.github.com> Signed-off-by: Alex Keeler <akeeler4227@gmail.com> * Update changelog post releasing 2.14.0 (#1162) (#1167) Signed-off-by: Thomas Farr <tsfarr@amazon.com> (cherry picked from commit 2a362a6) * Reduce required release approvals (#1168) Signed-off-by: Thomas Farr <tsfarr@amazon.com> Signed-off-by: Alex Keeler <akeeler4227@gmail.com> --------- Signed-off-by: Thomas Farr <tsfarr@amazon.com> Signed-off-by: Alex Keeler <akeeler4227@gmail.com> Signed-off-by: alex-keeler <59743435+alex-keeler@users.noreply.github.com> Co-authored-by: Thomas Farr <tsfarr@amazon.com> (cherry picked from commit 3902aef) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Xtansia
added a commit
that referenced
this pull request
Oct 22, 2024
* Generate the ml namespace (#1158) * Generate ml.register_model_group * Start neural search sample * Re-generate ShardStatistics * Re-generate ShardFailure * Re-generate Result * Re-generate WriteResponseBase * Generate ml.delete_model_group * Generate ml.register_model * Exclude legacy license from ml namespace * Generate ml.get_task * Generate ml.delete_task * Generate ml.delete_model * Generate ml.deploy_model * Generate ml.undeploy_model * Complete neural search sample * Generate ml.get_model * Add changelog entry * note * Fix tests --------- * Fix copy-paste mistake in NeuralSearch sample (#1161) * Support Radial Search Add minScore, maxDistance parameters to KnnQuery in order to support Radial Search, which was introduced in OpenSearch 2.14 https://opensearch.org/docs/latest/search-plugins/knn/radial-search-knn/ * Update CHANGELOG.md * Update changelog post releasing 2.14.0 (#1162) (#1167) (cherry picked from commit 2a362a6) * Reduce required release approvals (#1168) --------- (cherry picked from commit 3902aef) Signed-off-by: Thomas Farr <tsfarr@amazon.com> Signed-off-by: Alex Keeler <akeeler4227@gmail.com> Signed-off-by: alex-keeler <59743435+alex-keeler@users.noreply.github.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Thomas Farr <tsfarr@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix copy-paste mistake in NeuralSearch sample
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.