Remove "THIS CODE IS GENERATED" comments 1 of 12 #263
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
broken down into multiple commits as per opensearch-project#235 Signed-off-by: AarjavP <aarjavpatel@gmail.com>
AarjavP
requested review from
reta,
Bukhtawar,
dblock,
madhusudhankonda,
saratvemulapalli and
VachaShah
as code owners
|
Hi @AarjavP, sure this looks good! |
|
@VachaShah You sure you want 12 (!) PRs instead of one big one? What's the advantage? Let's just merge #235, I am A-OK on that. |
|
How about I push the 11 other commits into this PR and update the change log here only. I will close other 11 open PRs. This way we can also avoid merge conflicts and merge commits due to change log. For review you can select one commit at a time instead of all at once. |
This was referenced Dec 15, 2022
|
@AarjavP still looking to finish this? |
|
Done via #598 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
same as #235 but broken down into different commits / branches.
Please let me know how / when the changelog should be submitted.
I am creating just this 1 PR right now, but I have pushed other branches to my fork here: https://github.com/AarjavP/opensearch-java/branches
Most have < 200 files, and the one with most files has 213. If this is ok I can go ahead and create rest of the PRs.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.