Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport] [1.x] Fix: Make ChildrenAggregate as a SingleBucketAggregate (#306) #310

Merged
merged 1 commit into from
Jan 4, 2023

Conversation

sivaGH3
Copy link
Contributor

@sivaGH3 sivaGH3 commented Jan 3, 2023

Signed-off-by: Siva ychnagasivareddy@gmail.com

Description

Backport of #306

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@sivaGH3 sivaGH3 requested review from a team and madhusudhankonda as code owners January 3, 2023 14:18
@dblock dblock merged commit 2e715fa into opensearch-project:1.x Jan 4, 2023
@sivaGH3
Copy link
Contributor Author

sivaGH3 commented Jan 5, 2023

@reta , @dblock , I want this change in 1.0 version, as I am using 1.0 in my project, shall I raise a backport PR for 1.0 or is there another way? please let me know, thanks!

@sivaGH3 sivaGH3 deleted the backport-pr-306 branch January 5, 2023 04:56
@saratvemulapalli
Copy link
Member

@sivaGH3 we usually dont release for existing released versions as we follow semver[1]. Can you consume latest 1.x ?
@wbeckler do we do anything different with clients?

[1] https://opensearch.org/releases.html#maintenance-policy

@sivaGH3
Copy link
Contributor Author

sivaGH3 commented Jan 5, 2023

@saratvemulapalli , how to consume latest 1.x, what are the steps? thanks!

@dblock
Copy link
Member

dblock commented Jan 6, 2023

I think you'll have to build and consume a private jar for anything that's no longer supported, https://stackoverflow.com/questions/4955635/how-to-add-local-jar-files-to-a-maven-project. Does this work?

@siva-unravel
Copy link

thanks! @dblock

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants