Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] /_nodes/stats throwing serialization error #315

Merged
merged 1 commit into from
Jan 10, 2023

Conversation

reta
Copy link
Collaborator

@reta reta commented Jan 5, 2023

Signed-off-by: Andriy Redko andriy.redko@aiven.io

Description

/_nodes/stats, /_nodes/info throwing serialization error

Issues Resolved

Closes #47

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@reta
Copy link
Collaborator Author

reta commented Jan 5, 2023

@VachaShah do you know if we still generate the model classes for Java client? if yes, could you share the process please?

@VachaShah
Copy link
Collaborator

@VachaShah do you know if we still generate the model classes for Java client? if yes, could you share the process please?

The model classes are no longer generated for the Java client.

@reta reta force-pushed the issue-47 branch 5 times, most recently from 33e0d27 to dc0ad8c Compare January 6, 2023 19:36
Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
@reta reta marked this pull request as ready for review January 9, 2023 14:51
@reta
Copy link
Collaborator Author

reta commented Jan 10, 2023

@VachaShah could you please take a look? thanks!

Copy link
Collaborator

@VachaShah VachaShah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you @reta!

@VachaShah VachaShah merged commit f1fbe83 into opensearch-project:main Jan 10, 2023
@VachaShah
Copy link
Collaborator

@reta Can we also backport this fix to the 2.x branch?

@reta reta added the backport 2.x Backport to 2.x branch label Jan 11, 2023
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-315-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 f1fbe833d7cd925018b7ed3f9cd1c0684e25b993
# Push it to GitHub
git push --set-upstream origin backport/backport-315-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-315-to-2.x.

reta added a commit to reta/opensearch-java that referenced this pull request Jan 11, 2023
)

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
reta added a commit to reta/opensearch-java that referenced this pull request Jan 11, 2023
)

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
dblock pushed a commit that referenced this pull request Jan 12, 2023
Signed-off-by: Andriy Redko <andriy.redko@aiven.io>

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
@BrendonFaleiro BrendonFaleiro mentioned this pull request Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] /_nodes/stats throwing serialization error
3 participants