Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: ResponseCompression option. #322

Merged

Conversation

dblock
Copy link
Member

@dblock dblock commented Jan 11, 2023

Signed-off-by: dblock dblock@amazon.com

Description

Noticed that I couldn't disable Accept: gzip despite being advertised. Option not being copied from the builder.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: dblock <dblock@amazon.com>
@dblock dblock force-pushed the fix-transport-compression-option branch from 60c959c to 2880734 Compare January 11, 2023 23:05
@dblock
Copy link
Member Author

dblock commented Jan 14, 2023

@reta @VachaShah care to CR? thanks!

@VachaShah VachaShah merged commit 4165674 into opensearch-project:main Jan 14, 2023
@dblock dblock added the backport 2.x Backport to 2.x branch label Jan 15, 2023
@dblock dblock deleted the fix-transport-compression-option branch January 15, 2023 14:11
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jan 15, 2023
Signed-off-by: dblock <dblock@amazon.com>

Signed-off-by: dblock <dblock@amazon.com>
(cherry picked from commit 4165674)
dblock added a commit that referenced this pull request Jan 17, 2023
Signed-off-by: dblock <dblock@amazon.com>

(cherry picked from commit 4165674)
reta pushed a commit that referenced this pull request Jan 17, 2023
Signed-off-by: dblock <dblock@amazon.com>

(cherry picked from commit 4165674)

Co-authored-by: Daniel (dB.) Doubrovkine <dblock@amazon.com>
@BrendonFaleiro BrendonFaleiro mentioned this pull request Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants