Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade backport workflow. #334

Merged
merged 1 commit into from
Jan 23, 2023
Merged

Conversation

dblock
Copy link
Member

@dblock dblock commented Jan 17, 2023

Signed-off-by: dblock dblock@amazon.com

Description

I copied the workflow from OpenSearch to attempt to fix DCO problems we see in #332. I don't know if it's right and whether it will work 😅 @VachaShah ? Particularly I don't know whether if: ${{ contains(github.event.label.name, 'backport') }} is needed, where that event comes from.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: dblock <dblock@amazon.com>
@VachaShah
Copy link
Collaborator

The new version of backport offers some new features like files to skip. It doesn't address the DCO issue, it needs further looking into 😞

@dblock
Copy link
Member Author

dblock commented Jan 19, 2023

Thanks @VachaShah. Should we merge this one anyway or close?

@VachaShah
Copy link
Collaborator

Thanks @VachaShah. Should we merge this one anyway or close?

We can merge this.

@dblock dblock merged commit b522980 into opensearch-project:main Jan 23, 2023
@dblock dblock deleted the upgrade-backport branch January 23, 2023 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants