[Backport 2.x] Add option to set headers and sort options in cat requests #413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![opensearch-trigger-bot[bot]](https://avatars.githubusercontent.com/u/80134844?s=60&v=4){kind=small}
opensearch-trigger-bot
bot
requested review from
reta,
Bukhtawar,
dblock,
madhusudhankonda,
saratvemulapalli and
VachaShah
as code owners
reta
approved these changes
Mar 21, 2023
|
Looks like the backport will need some manual work @MarinaRazumovsky , tests failed. |
|
|
||
| package org.opensearch.client.opensearch.integTest.restclient; | ||
|
|
||
| import org.apache.hc.core5.http.HttpHost; |
There was a problem hiding this comment.
@dblock , it should be this import, but I have not permissions to change code
import org.apache.http.HttpHost;
There was a problem hiding this comment.
@MarinaRazumovsky I will take care of it, thank you
There was a problem hiding this comment.
Thanks both! Next time feel free to open another PR, might be faster than waiting for a maintainer to amend/fix/force push.
* Adding x-amz-content-sha256 header for signed requests (#339) * Adding X-Amz-Content-Sha256 header for signed requests Signed-off-by: Vacha Shah <vachshah@amazon.com> * Adding CHANGELOG entry Signed-off-by: Vacha Shah <vachshah@amazon.com> * Adding documentation comment Signed-off-by: Vacha Shah <vachshah@amazon.com> * Adding tests Signed-off-by: Vacha Shah <vachshah@amazon.com> * Addressing comments Signed-off-by: Vacha Shah <vachshah@amazon.com> * Addressing comments Signed-off-by: Vacha Shah <vachshah@amazon.com> * Removing refresh policy for integ tests for Sigv4 Signed-off-by: Vacha Shah <vachshah@amazon.com> * Updating the developer guide Signed-off-by: Vacha Shah <vachshah@amazon.com> Signed-off-by: Vacha Shah <vachshah@amazon.com> Signed-off-by: MarinaRazumovsky <rzm.mrn@gmail.com> * Fix issue with completion suggester being parsed as term suggester. (#347) * Fix issue with completion suggester being parsed as term suggester. This commit fixes the issue where a completion suggester search request was being parsed as a term suggester and failing due to "Missing required property 'TermSuggestOption.score'" This solution was originally proposed by Github user @apatrida Signed-off-by: Dan Hart <git@danielhart.me> * Remove commented code Signed-off-by: Dan Hart <git@danielhart.me> * Fix format of changelog item Signed-off-by: Dan Hart <git@danielhart.me> Signed-off-by: Dan Hart <git@danielhart.me> Signed-off-by: MarinaRazumovsky <rzm.mrn@gmail.com> * Update USER_GUIDE to use exact AWS brand names (#352) Minor update to use exact brand names. "OpenSearch" is rather overloaded to I find it less confusing to be precise in the naming. Signed-off-by: Andrew Ross <andrross@amazon.com> Signed-off-by: Andrew Ross <andrross@amazon.com> Signed-off-by: MarinaRazumovsky <rzm.mrn@gmail.com> * Bumps Jackson from 2.14.1 to 2.14.2 (#357) Signed-off-by: Andriy Redko <andriy.redko@aiven.io> Signed-off-by: MarinaRazumovsky <rzm.mrn@gmail.com> * Bulk UpdateOperation misses upsert options (#353) * Bulk UpdateOperation misses upsert options Signed-off-by: Andriy Redko <andriy.redko@aiven.io> * Fix formatting Signed-off-by: Andriy Redko <andriy.redko@aiven.io> --------- Signed-off-by: Andriy Redko <andriy.redko@aiven.io> Signed-off-by: MarinaRazumovsky <rzm.mrn@gmail.com> * Upgrading compatibility to opensearch 2.5 (#367) * Upgrading compatibility to opensearch 2.5 Signed-off-by: amitai stern <123amitai@gmail.com> * latest 2.4 version Signed-off-by: amitai stern <123amitai@gmail.com> * keep existing compatibility matrix rows, this pr adds a new row for versions of opensearch after 2.3.0 Signed-off-by: amitai stern <123amitai@gmail.com> --------- Signed-off-by: amitai stern <123amitai@gmail.com> Signed-off-by: MarinaRazumovsky <rzm.mrn@gmail.com> * add option to set columns into cat indices request Signed-off-by: MarinaRazumovsky <rzm.mrn@gmail.com> * add changelog Signed-off-by: MarinaRazumovsky <rzm.mrn@gmail.com> * changes in CatRequestBase, IndicesRequest, NodesRequest, RecoveryRequest and add tests Signed-off-by: MarinaRazumovsky <rzm.mrn@gmail.com> * Feature/range aggregation fix 369 (#370) * test: create integration tests for date_range and range aggregation (#369) Signed-off-by: Dominik Szczepanczyk <szczepanczyk.dominik@gmail.com> * fix: add a missing key propery to the RangeBucket (#369) Signed-off-by: Dominik Szczepanczyk <szczepanczyk.dominik@gmail.com> * docs: add CHANGELOG entry (#369) Signed-off-by: Dominik Szczepanczyk <szczepanczyk.dominik@gmail.com> --------- Signed-off-by: Dominik Szczepanczyk <szczepanczyk.dominik@gmail.com> Signed-off-by: MarinaRazumovsky <rzm.mrn@gmail.com> * Fixing integration tests (#375) * Fixing integration tests Signed-off-by: Vacha Shah <vachshah@amazon.com> * Updating the test with a non-exact check Signed-off-by: Vacha Shah <vachshah@amazon.com> --------- Signed-off-by: Vacha Shah <vachshah@amazon.com> Signed-off-by: MarinaRazumovsky <rzm.mrn@gmail.com> * Adding bulk request example in user guide (#373) Signed-off-by: Vacha Shah <vachshah@amazon.com> Signed-off-by: MarinaRazumovsky <rzm.mrn@gmail.com> * Fixing issue when tracktotalhits is disabled (#372) * Fixing issue when tracktotalhits is disabled Signed-off-by: Vacha Shah <vachshah@amazon.com> * Update Changelog Signed-off-by: Vacha Shah <vachshah@amazon.com> --------- Signed-off-by: Vacha Shah <vachshah@amazon.com> Co-authored-by: Daniel (dB.) Doubrovkine <dblock@amazon.com> Signed-off-by: MarinaRazumovsky <rzm.mrn@gmail.com> * changes changelog Signed-off-by: MarinaRazumovsky <rzm.mrn@gmail.com> * Bump io.github.classgraph:classgraph from 4.8.154 to 4.8.156 (#390) * Bump io.github.classgraph:classgraph from 4.8.154 to 4.8.156 Bumps [io.github.classgraph:classgraph](https://github.com/classgraph/classgraph) from 4.8.154 to 4.8.156. - [Release notes](https://github.com/classgraph/classgraph/releases) - [Commits](classgraph/classgraph@classgraph-4.8.154...classgraph-4.8.156) --- updated-dependencies: - dependency-name: io.github.classgraph:classgraph dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * Update changelog Signed-off-by: dependabot[bot] <support@github.com> --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com> Signed-off-by: MarinaRazumovsky <rzm.mrn@gmail.com> * Add 2PR approval to release workflow (#383) Signed-off-by: Sayali Gaikawad <gaiksaya@amazon.com> Signed-off-by: MarinaRazumovsky <rzm.mrn@gmail.com> * Adding an example to use raw JSON class instead of target classes (#385) Signed-off-by: Vacha Shah <vachshah@amazon.com> Signed-off-by: MarinaRazumovsky <rzm.mrn@gmail.com> * Update Gradle to 8.0.2 (#392) Signed-off-by: Andriy Redko <andriy.redko@aiven.io> Signed-off-by: MarinaRazumovsky <rzm.mrn@gmail.com> * Add "mappings" field to IndexSettings object (#382) Signed-off-by: Ilya Lukyanovich <l000kian@gmail.com> Signed-off-by: MarinaRazumovsky <rzm.mrn@gmail.com> * Created untriaged issue workflow. (#364) Signed-off-by: dblock <dblock@amazon.com> Signed-off-by: MarinaRazumovsky <rzm.mrn@gmail.com> * Bump io.github.classgraph:classgraph from 4.8.156 to 4.8.157 in /java-client (#403) * Bump io.github.classgraph:classgraph in /java-client Bumps [io.github.classgraph:classgraph](https://github.com/classgraph/classgraph) from 4.8.156 to 4.8.157. - [Release notes](https://github.com/classgraph/classgraph/releases) - [Commits](classgraph/classgraph@classgraph-4.8.156...classgraph-4.8.157) --- updated-dependencies: - dependency-name: io.github.classgraph:classgraph dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * Update changelog Signed-off-by: dependabot[bot] <support@github.com> --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com> Signed-off-by: MarinaRazumovsky <rzm.mrn@gmail.com> * Add buffered lookahead for Jackson (#338) Signed-off-by: luneo7 <luneo7@gmail.com> Signed-off-by: MarinaRazumovsky <rzm.mrn@gmail.com> * Mask env values for snapshots (#411) Signed-off-by: Sayali Gaikawad <gaiksaya@amazon.com> Signed-off-by: MarinaRazumovsky <rzm.mrn@gmail.com> * option to set headers and sort into cat requests Signed-off-by: MarinaRazumovsky <rzm.mrn@gmail.com> * fix test Signed-off-by: MarinaRazumovsky <rzm.mrn@gmail.com> * fix changelog Signed-off-by: MarinaRazumovsky <rzm.mrn@gmail.com> * add cat examples into USER_GUID Signed-off-by: MarinaRazumovsky <rzm.mrn@gmail.com> --------- Signed-off-by: Vacha Shah <vachshah@amazon.com> Signed-off-by: MarinaRazumovsky <rzm.mrn@gmail.com> Signed-off-by: Dan Hart <git@danielhart.me> Signed-off-by: Andrew Ross <andrross@amazon.com> Signed-off-by: Andriy Redko <andriy.redko@aiven.io> Signed-off-by: amitai stern <123amitai@gmail.com> Signed-off-by: Dominik Szczepanczyk <szczepanczyk.dominik@gmail.com> Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: Sayali Gaikawad <gaiksaya@amazon.com> Signed-off-by: Ilya Lukyanovich <l000kian@gmail.com> Signed-off-by: dblock <dblock@amazon.com> Signed-off-by: luneo7 <luneo7@gmail.com> Co-authored-by: Vacha Shah <vachshah@amazon.com> Co-authored-by: Danny Hart <git@danielhart.me> Co-authored-by: Andrew Ross <andrross@amazon.com> Co-authored-by: Andriy Redko <andriy.redko@aiven.io> Co-authored-by: amitai stern <123amitai@gmail.com> Co-authored-by: szczepanczykd <48957041+szczepanczykd@users.noreply.github.com> Co-authored-by: Daniel (dB.) Doubrovkine <dblock@amazon.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com> Co-authored-by: Sayali Gaikawad <61760125+gaiksaya@users.noreply.github.com> Co-authored-by: Ilya Lukyanovich <ilya.lukyanovich@dataart.com> Co-authored-by: Lucas Rogerio Caetano Ferreira <luneo7@users.noreply.github.com> (cherry picked from commit 938170a) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
reta
force-pushed
the
backport/backport-412-to-2.x
branch
from
1b186cc to
ec17c60
Compare
|
@dblock @MarinaRazumovsky all good now :) |
dblock
approved these changes
Mar 21, 2023
|
@dblock when can we expect the next release of this client with the above changes? is there a cadence/schedule of some sort? (before we go ahead and work off a forked version...) |
|
@VachaShah - I opened #426 Not sure regarding the other two commits since @MarinaRazumovsky's fix if they should be included or not. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 938170a from #412.