Fixes deserialization of enums when using booleans instead of strings #482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Patrick Schlindwein <patrick.schlindwein@bolindalabs.com>
patschl
requested review from
reta,
Bukhtawar,
dblock,
szczepanczykd,
madhusudhankonda,
saratvemulapalli and
VachaShah
as code owners
Signed-off-by: Patrick Schlindwein <patrick.schlindwein@bolindalabs.com>
|
Before I merge, what tests would fail if |
Signed-off-by: Patrick Schlindwein <patrick.schlindwein@bolindalabs.com>
|
I just tried it and actually no test fails, it's just an unexpected behaviour to implicitly support boolean deserialization with the Enum Deserializer. If you'd like to I could move the new deserialization logic to the existing Deserializer. |
Yes yes! |
|
Also please update documentation/README. |
patschl
force-pushed
the
fix_enum_boolean_deserialization
branch
from
d79afc5 to
b372d24
Compare
|
I made the recommended changes and updated the CHANGELOG.md along with the Javadoc. |
Signed-off-by: Patrick Schlindwein <patrick.schlindwein@bolindalabs.com>
patschl
force-pushed
the
fix_enum_boolean_deserialization
branch
from
b372d24 to
125b78f
Compare
dblock
approved these changes
May 18, 2023
reta
approved these changes
May 18, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
May 18, 2023
…#482) * Fixes deserialization of enums when using booleans instead of strings Signed-off-by: Patrick Schlindwein <patrick.schlindwein@bolindalabs.com> * Fixes CHANGELOG.md Signed-off-by: Patrick Schlindwein <patrick.schlindwein@bolindalabs.com> * Fixes checkstyle failure Signed-off-by: Patrick Schlindwein <patrick.schlindwein@bolindalabs.com> * Include boolean support in existing JsonEnum.Deserializer Signed-off-by: Patrick Schlindwein <patrick.schlindwein@bolindalabs.com> --------- Signed-off-by: Patrick Schlindwein <patrick.schlindwein@bolindalabs.com> (cherry picked from commit 5af5674) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
dblock
pushed a commit
that referenced
this pull request
May 21, 2023
…#482) (#488) * Fixes deserialization of enums when using booleans instead of strings * Fixes CHANGELOG.md * Fixes checkstyle failure * Include boolean support in existing JsonEnum.Deserializer --------- (cherry picked from commit 5af5674) Signed-off-by: Patrick Schlindwein <patrick.schlindwein@bolindalabs.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allows for boolean values for enums which support those, eg.
DynamicMappingandRefresh.Issues Resolved
Fixes #256
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.