[Backport 2.x] Migrating from checkstyle to spotless (#648 and #651) #661
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ect#648) * Adding spotless for checking and fixing formatting and removing checkstyle Signed-off-by: Vacha Shah <vachshah@amazon.com> * Making build task depend on spotlessJavaCheck Signed-off-by: Vacha Shah <vachshah@amazon.com> * Removing resources and documentation related to checkstyle Signed-off-by: Vacha Shah <vachshah@amazon.com> * Running spotless for json, transport and util folders Signed-off-by: Vacha Shah <vachshah@amazon.com> * Running spotless for samples Signed-off-by: Vacha Shah <vachshah@amazon.com> * Removing commented code Signed-off-by: Vacha Shah <vachshah@amazon.com> --------- Signed-off-by: Vacha Shah <vachshah@amazon.com>
Signed-off-by: Vacha Shah <vachshah@amazon.com>
VachaShah
requested review from
reta,
Bukhtawar,
dblock,
madhusudhankonda and
saratvemulapalli
as code owners
Signed-off-by: Vacha Shah <vachshah@amazon.com>
Signed-off-by: Vacha Shah <vachshah@amazon.com>
dblock
approved these changes
Oct 12, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is the backport for all spotless changes on main from PRs #648 and #651.
Issues Resolved
List any issues this PR will resolve, e.g. Closes [...].
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.