-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding workflow to increment version after release #664
Merged
dblock
merged 2 commits into
opensearch-project:main
from
VachaShah:increment-version-workflow
Oct 16, 2023
Merged
Adding workflow to increment version after release #664
dblock
merged 2 commits into
opensearch-project:main
from
VachaShah:increment-version-workflow
Oct 16, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VachaShah
requested review from
reta,
Bukhtawar,
dblock,
szczepanczykd,
madhusudhankonda and
saratvemulapalli
as code owners
October 12, 2023 23:54
dblock
previously approved these changes
Oct 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works for me. Generally maybe it's easier/more robust to write these things in gradle.
Do update CHANGELOG.
Signed-off-by: Vacha Shah <vachshah@amazon.com>
Signed-off-by: Vacha Shah <vachshah@amazon.com>
VachaShah
force-pushed
the
increment-version-workflow
branch
from
October 13, 2023 19:18
cc64972
to
33a09a8
Compare
Added the changelog. Do you mean to write this script in gradle? |
reta
approved these changes
Oct 13, 2023
dblock
approved these changes
Oct 16, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 16, 2023
* Adding workflow to increment version after release on the 2.x branch Signed-off-by: Vacha Shah <vachshah@amazon.com> * Added CHANGELOG Signed-off-by: Vacha Shah <vachshah@amazon.com> --------- Signed-off-by: Vacha Shah <vachshah@amazon.com> (cherry picked from commit 7d38fe5) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
VachaShah
pushed a commit
that referenced
this pull request
Oct 16, 2023
* Adding workflow to increment version after release on the 2.x branch * Added CHANGELOG --------- (cherry picked from commit 7d38fe5) Signed-off-by: Vacha Shah <vachshah@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
After each release, we need to increment the version manually. Adding a workflow for it.
I verified this workflow on my fork: it successfully raised a PR VachaShah#11
Issues Resolved
Resolves #190
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.