-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add indexing and search index settings #667
Add indexing and search index settings #667
Conversation
This commit adds indexing and search settings to index settings. These settings allow configuring of slow logs for indexing and search, as well as setting search idle after. Search idle after duplicates the individual IndexSettings::searchIdleAfter property, but this pattern is already present e.g. IndexSettings::blocks and IndexSettings::blocksReadOnly, IndexSettings::blocksRead, etc. Signed-off-by: Russ Cam <russcam@canva.com>
Signed-off-by: Russ Cam <russcam@canva.com>
6726aca
to
45d59a6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me! Do you think you could add some words to the user guide(s) in https://github.com/opensearch-project/opensearch-java/tree/main/guides and maybe a sample to https://github.com/opensearch-project/opensearch-java/tree/main/samples for these features?
java-client/src/main/java/org/opensearch/client/opensearch/indices/IndexSettingsIndexing.java
Show resolved
Hide resolved
Signed-off-by: Russ Cam <russcam@canva.com>
@dblock I've added a sample and docs |
Thank you @russcam! Can you apply |
Signed-off-by: Russ Cam <russcam@canva.com>
@VachaShah done! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @russcam!
* Add indexing and search index settings This commit adds indexing and search settings to index settings. These settings allow configuring of slow logs for indexing and search, as well as setting search idle after. Search idle after duplicates the individual IndexSettings::searchIdleAfter property, but this pattern is already present e.g. IndexSettings::blocks and IndexSettings::blocksReadOnly, IndexSettings::blocksRead, etc. Signed-off-by: Russ Cam <russcam@canva.com> * add changelog entry Signed-off-by: Russ Cam <russcam@canva.com> * Add documentation and sample Signed-off-by: Russ Cam <russcam@canva.com> * Update IndexTemplates Signed-off-by: Russ Cam <russcam@canva.com> --------- Signed-off-by: Russ Cam <russcam@canva.com> (cherry picked from commit 9408cc2) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* Add indexing and search index settings This commit adds indexing and search settings to index settings. These settings allow configuring of slow logs for indexing and search, as well as setting search idle after. Search idle after duplicates the individual IndexSettings::searchIdleAfter property, but this pattern is already present e.g. IndexSettings::blocks and IndexSettings::blocksReadOnly, IndexSettings::blocksRead, etc. * add changelog entry * Add documentation and sample * Update IndexTemplates --------- (cherry picked from commit 9408cc2) Signed-off-by: Russ Cam <russcam@canva.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* Add indexing and search index settings This commit adds indexing and search settings to index settings. These settings allow configuring of slow logs for indexing and search, as well as setting search idle after. Search idle after duplicates the individual IndexSettings::searchIdleAfter property, but this pattern is already present e.g. IndexSettings::blocks and IndexSettings::blocksReadOnly, IndexSettings::blocksRead, etc. Signed-off-by: Russ Cam <russcam@canva.com> * add changelog entry Signed-off-by: Russ Cam <russcam@canva.com> * Add documentation and sample Signed-off-by: Russ Cam <russcam@canva.com> * Update IndexTemplates Signed-off-by: Russ Cam <russcam@canva.com> --------- Signed-off-by: Russ Cam <russcam@canva.com> Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
* Add indexing and search index settings This commit adds indexing and search settings to index settings. These settings allow configuring of slow logs for indexing and search, as well as setting search idle after. Search idle after duplicates the individual IndexSettings::searchIdleAfter property, but this pattern is already present e.g. IndexSettings::blocks and IndexSettings::blocksReadOnly, IndexSettings::blocksRead, etc. Signed-off-by: Russ Cam <russcam@canva.com> * add changelog entry Signed-off-by: Russ Cam <russcam@canva.com> * Add documentation and sample Signed-off-by: Russ Cam <russcam@canva.com> * Update IndexTemplates Signed-off-by: Russ Cam <russcam@canva.com> --------- Signed-off-by: Russ Cam <russcam@canva.com> Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
Description
This PR adds indexing and search settings to index settings. These settings allow configuring of slow logs for indexing and search, as well as setting search idle after.
Search idle after duplicates the individual
IndexSettings::searchIdleAfter
property, but this pattern is already present e.g.IndexSettings::blocks
andIndexSettings::blocksReadOnly
,IndexSettings::blocksRead
, etc.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.