Add support neural query type #674
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GranT1337
requested review from
reta,
Bukhtawar,
dblock,
szczepanczykd,
madhusudhankonda,
saratvemulapalli and
VachaShah
as code owners
GranT1337
force-pushed
the
neural-query
branch
from
0195446 to
978a021
Compare
Signed-off-by: Kirill_Ostanin <Kirill_Ostanin@epam.com>
dblock
previously approved these changes
Oct 20, 2023
There was a problem hiding this comment.
Looks good! Do you think yo could add a doc and a working sample into https://github.com/opensearch-project/opensearch-java/tree/main/guides and https://github.com/opensearch-project/opensearch-java/tree/main/samples as part of this?
|
@GranT1337 Looks like you'll need to fix spotless and such ... I'll change this whole CI doesn't run on first time committer nonsense |
|
@GranT1337 LGTM as well, please add changelog entry, thank you |
Signed-off-by: Kirill Ostanin <grantkirill@gmail.com>
Signed-off-by: Kirill Ostanin <grantkirill@gmail.com>
@dblock Creating a sample is quite difficult. To make a simple example, you need to:
The model is quite large for a simple example, and opensearch-java currently does not allow performing these steps through Java code, i.e., sending JSON text is required. |
dblock
previously approved these changes
Oct 23, 2023
reta
reviewed
Oct 23, 2023
java-client/src/main/java/org/opensearch/client/opensearch/_types/query_dsl/NeuralQuery.java
Outdated
Show resolved
Hide resolved
reta
reviewed
Oct 23, 2023
java-client/src/main/java/org/opensearch/client/opensearch/_types/query_dsl/NeuralQuery.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Kirill Ostanin <grantkirill@gmail.com>
Signed-off-by: Kirill Ostanin <grantkirill@gmail.com>
reta
approved these changes
Oct 24, 2023
dblock
approved these changes
Oct 24, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 24, 2023
* Add support neural query type Signed-off-by: Kirill_Ostanin <Kirill_Ostanin@epam.com> * fix spotless Signed-off-by: Kirill Ostanin <grantkirill@gmail.com> * Update CHANGELOG.md Signed-off-by: Kirill Ostanin <grantkirill@gmail.com> * refactoring Signed-off-by: Kirill Ostanin <grantkirill@gmail.com> * attempt to restart integration tests Signed-off-by: Kirill Ostanin <grantkirill@gmail.com> --------- Signed-off-by: Kirill_Ostanin <Kirill_Ostanin@epam.com> Signed-off-by: Kirill Ostanin <grantkirill@gmail.com> Co-authored-by: Kirill Ostanin <grantkirill@gmail.com> (cherry picked from commit 4603af9) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
VachaShah
pushed a commit
that referenced
this pull request
Oct 24, 2023
* Add support neural query type * fix spotless * Update CHANGELOG.md * refactoring * attempt to restart integration tests --------- (cherry picked from commit 4603af9) Signed-off-by: Kirill_Ostanin <Kirill_Ostanin@epam.com> Signed-off-by: Kirill Ostanin <grantkirill@gmail.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Kirill Ostanin <grantkirill@gmail.com>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds support for neural query type for neural text search
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.