Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accept null values in arrays #679

Conversation

karthiks3000
Copy link
Contributor

Description

This is PR is based on this PR from the elasticsearch-java library. Reproducing it here since the library is licensed under Apache 2.0.

Issues Resolved

Closes Issue 176

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@dblock
Copy link
Member

dblock commented Oct 23, 2023

@karthiks3000 Please git amend with -s for DCO signing. Thanks!

Karthik Subramanian and others added 4 commits October 23, 2023 15:56
Signed-off-by: Karthik Subramanian <ksubramanian@scholastic.com>
Signed-off-by: Karthik Subramanian <ksubramanian@scholastic.com>
…t#680)

* Bump org.owasp.dependencycheck from 8.4.0 to 8.4.2

Bumps org.owasp.dependencycheck from 8.4.0 to 8.4.2.

---
updated-dependencies:
- dependency-name: org.owasp.dependencycheck
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

* Update changelog

Signed-off-by: dependabot[bot] <support@github.com>

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com>
Signed-off-by: Karthik Subramanian <ksubramanian@scholastic.com>
Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
Signed-off-by: Karthik Subramanian <ksubramanian@scholastic.com>
@karthiks3000 karthiks3000 force-pushed the issue-176-accept-null-in-arrays branch from 8fb5219 to 658660e Compare October 23, 2023 19:57
@karthiks3000
Copy link
Contributor Author

@dblock I've added the DCO to my commits, but syncing my forks main branch somehow seems to have updated my PR and included changes @reta made. Not sure how to fix this?

@dblock
Copy link
Member

dblock commented Oct 23, 2023

@karthiks3000
Copy link
Contributor Author

I'll just create another PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Accept null values in arrays
3 participants